Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CondaEnvironmentV0] Migrated to Node10 #15249

Merged
merged 5 commits into from
Sep 7, 2021
Merged

[CondaEnvironmentV0] Migrated to Node10 #15249

merged 5 commits into from
Sep 7, 2021

Conversation

AnnaOpareva
Copy link
Contributor

Task name: CondaEnvironmentV0

Description: Updated dependencies

Documentation changes required: (Y/N) No

Added unit tests: (Y/N) No

Attached related issue: (Y/N) #15189

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@AnnaOpareva AnnaOpareva requested a review from a team as a code owner September 2, 2021 14:22
@AnnaOpareva AnnaOpareva changed the title migrate to node 10 [CondaEnvironmentV0] Migrated to Node10 Sep 2, 2021
DaniilShmelev
DaniilShmelev reviewed Sep 3, 2021
View reviewed changes
Copy link
Contributor

@DaniilShmelev DaniilShmelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also change MochaDone type in tests to Mocha.Done?

@EzzhevNikita EzzhevNikita requested a review from a team September 3, 2021 14:33
@AnnaOpareva
Copy link
Contributor Author

Could you please also change MochaDone type in tests to Mocha.Done?

Thanks!

@AnnaOpareva AnnaOpareva merged commit ac114d9 into master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniilShmelev DaniilShmelev DaniilShmelev left review comments

@EzzhevNikita EzzhevNikita EzzhevNikita approved these changes

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnnaOpareva @anatolybolshakov @EzzhevNikita @DaniilShmelev