Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic to JenkinsQueueJobV2 #15211

Merged
merged 15 commits into from
Aug 26, 2021

Conversation

kuleshovilya
Copy link
Contributor

@kuleshovilya kuleshovilya commented Aug 24, 2021

Task name: JenkinsQueueJobV2
Description: Added variables and logic for Jenkins retry on failed connection
Documentation changes required: Y
Added unit tests: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@kuleshovilya kuleshovilya requested a review from a team as a code owner August 24, 2021 14:11
@kuleshovilya kuleshovilya changed the title Users/kuleshovilya/add retry jenkins dts 1869075 Add retry logic to JenkinsQueueJobV2 Aug 24, 2021
Tasks/JenkinsQueueJobV2/job.ts Outdated Show resolved Hide resolved
Tasks/JenkinsQueueJobV2/job.ts Outdated Show resolved Hide resolved
Tasks/JenkinsQueueJobV2/job.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@DaniilShmelev DaniilShmelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes manually, LGTM.

@kuleshovilya kuleshovilya requested a review from a team August 25, 2021 09:47
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me test it also

Tasks/JenkinsQueueJobV2/job.ts Outdated Show resolved Hide resolved
Tasks/JenkinsQueueJobV2/job.ts Outdated Show resolved Hide resolved
@anatolybolshakov
Copy link
Contributor

Works fine for me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants