Add GradleV3 task to fix invalid demands issue #15174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! Could it make sense to update related localization files also in Localization branch? |
1 task
|
@anatolybolshakov Sure, I've created a PR: #15178 |
anatolybolshakov
approved these changes
Aug 20, 2021
|
Tested functionality manually, LGTM! |
kuleshovilya
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: Gradle
Description: Remove gradle demand; fix tests; add GradleV3 to make-options.json
Difference: DaniilShmelev/diff@03fb23a
Previously jobs with the Gradle task would not run even if JDK was installed on the agent. The only thing that's changed in V3 is that the
javademand is removed.Documentation changes required: Yes
Added unit tests: No (only fixed the old ones since they had hardcoded "GradleV2" strings)
Checklist: