Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PublishBuildArtifactsV1] Delete hardcoded "/E" option not to copy subdirectories #15046

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2021

Task name: PublishBuildArtifactsV1

Description:
Delete from robocopy call hardcoded "/E" option and replace it with variable. This variable will contain "/E" option if "PathToPublish" is not a file, and it will be empty string in case "PathToPublish" is file

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) #14984

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@ghost ghost self-requested a review as a code owner July 15, 2021 14:18
@ghost ghost changed the title [PublishBuildArtifactsV1] Delete hardcoded "/E" option not to copy subdirectories [WIP][PublishBuildArtifactsV1] Delete hardcoded "/E" option not to copy subdirectories Jul 15, 2021
@ghost ghost marked this pull request as draft July 15, 2021 18:04
@ghost ghost changed the title [WIP][PublishBuildArtifactsV1] Delete hardcoded "/E" option not to copy subdirectories [PublishBuildArtifactsV1] Delete hardcoded "/E" option not to copy subdirectories Aug 4, 2021
Tatyana Kostromskaya and others added 2 commits August 4, 2021 14:33
@ghost ghost marked this pull request as ready for review August 4, 2021 11:34
@max-zaytsev
Copy link

@tatyana-kostromskaya, @anatolybolshakov Could this be a breaking change for the customers who use this task with a current behavior?

@ghost
Copy link
Author

ghost commented Aug 4, 2021

@tatyana-kostromskaya, @anatolybolshakov Could this be a breaking change for the customers who use this task with a current behavior?

I discussed it with @anatolybolshakov. This behavior is not documented so we can consider these changes as bug fixing of unexpected behavior.

@ghost ghost self-requested a review August 5, 2021 07:21
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Could you please take a look at the comments?

@anatolybolshakov anatolybolshakov self-requested a review August 5, 2021 18:10
Tatyana Kostromskaya and others added 2 commits August 9, 2021 09:53
@ghost ghost merged commit 350655f into master Aug 10, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants