Add retry for individual files in CopyFilesV2 task #15035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com/microsoft/azure-pipelines-tasks into users/EzzhevNikita/copy-files-with-retry
alexander-smolyakov
approved these changes
Jul 14, 2021
EzzhevNikita
force-pushed
the
users/EzzhevNikita/copy-files-with-retry
branch
from
d317e21 to
919c0c7
Compare
max-zaytsev
reviewed
Jul 15, 2021
max-zaytsev
approved these changes
Jul 15, 2021
EzzhevNikita
added a commit
that referenced
this pull request
Jul 16, 2021
* Added retry logic for copufiles task * Fixed tests * Move input in proper place * Style fixed * Fix tests * Addressed review points * Fix code style * Remove individual timeouts * Pass custom values to retryOptions * Fix formatting Co-authored-by: Maxim Zaytsev <v-mazayt@microsoft.com>
EzzhevNikita
added a commit
that referenced
this pull request
Jul 16, 2021
* Added retry logic for copufiles task * Fixed tests * Move input in proper place * Style fixed * Fix tests * Addressed review points * Fix code style * Remove individual timeouts * Pass custom values to retryOptions * Fix formatting Co-authored-by: Maxim Zaytsev <v-mazayt@microsoft.com> Co-authored-by: Maxim Zaytsev <v-mazayt@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: CopyFilesV2
Description: Added retry logic to all the methods that are used for working with files. Those methods are receptive to file access issues and retry helps in most cases to address problems with file copying and deleting especially for files that are accessing through UNC paths.
Documentation changes required: (Y/N) Y
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N
Checklist: