Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CopyFilesV2] Added 'ignoreMakeDirErrors' - to be able to ignore errors during target folder creation #14914

Merged

Conversation

anatolybolshakov
Copy link
Contributor

@anatolybolshakov anatolybolshakov commented May 31, 2021

Task name: CopyFilesV2

Description: added 'ignoreMakeDirErrors' input for CopyFilesV2 task - to be able to ignore errors during creation of target folder. This is useful for execution by several agents in parallel - with one target folder.

Documentation changes required: Y - in progress.

Added unit tests: Y

  • added tests for case when ignoreMakeDirErrors is true and false.

Attached related issue: #14892

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected - in progress

@anatolybolshakov anatolybolshakov force-pushed the users/anatolybolshakov/fix14892_CopyFiles_mkdir_fix branch from dcfad51 to 8c20359 Compare May 31, 2021 16:54
@anatolybolshakov anatolybolshakov requested a review from a team May 31, 2021 16:58
Copy link
Contributor

@EzzhevNikita EzzhevNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But seems you forgot to bump the task version. Could you please do it?

@anatolybolshakov
Copy link
Contributor Author

LGTM! But seems you forgot to bump the task version. Could you please do it?

Thanks for heads up! Fixed it

@anatolybolshakov anatolybolshakov merged commit 14e609d into master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants