[PublishTestResultsV2] Add option to fail task if no test result files are found #14868
Conversation
|
|
walliski
force-pushed
the
fail-if-no-results
branch
2 times, most recently
from
964f70b to
12ccb49
Compare
walliski
changed the title
walliski
changed the title
|
This PR is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the PR otherwise this will be closed in 5 days |
|
Soooo is this going somewhere? |
|
Why is that a problem to review this nice improvement for 7 months !? |
|
@shailesh-sk Could you do a review on this PR. Or maybe some of the more active contributers could do a review? |
|
reping here since it's a really really useful feature! could anyone go through the code review? |
|
Could we merge this essential feature any time soon? @walliski @shailesh-sk |
|
@the-rule I can't really do anything about it, its up for the maintainers to merge it. To me its infuriating that such a simple change, a feature that exists in pretty much all CI systems, has not been merged yet, and has been actively ignored for over a year. |
|
@shailesh-sk ping-ping |
Totally agree, to me this change is not even a feature but a bug fix! |
|
@shailesh-sk I would completely agree with @the-rule ! |
|
Maybe anyone else who can review this PR? @DenisRumyantsev? |
Adds an option that lets the user configure the task to fail in case no test result files have been found. This serves as a safeguard to make sure that the test-run task and this task has been configured properly to find the test result files. Solves microsoft#13275
Instead of using hardcoded English string, lets use the localized version that already exists.
walliski
force-pushed
the
fail-if-no-results
branch
from
5a413b0 to
63cb1ed
Compare
|
@navin22 can you maybe help? This is such a small PR with incredibly added value... I've seen you've done a review on this task in the past hence I'm mentioning you :-) |
|
Sorry folks, let me find the current maintainers. |
|
This PR is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the PR otherwise this will be closed in 5 days |
|
Beep boop |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Merged in Pull request: #18931 |
Task name: PublishTestResultsV2
Description:
Adds an option that lets the user configure the task to fail in case no
test result files have been found. This serves as a safeguard to make
sure that the test-run task and this task has been configured properly
to find the test result files.
We are defaulting to not failing the task on missing files, to keep current behavior.
Documentation changes required: Y
I guess this option should be documented.
Added unit tests: N
Not sure how this should be tested, as the "Warning" functionality doesn't seem to be tested either?
Attached related issue: Y
Solves #13275
Checklist:
I have no idea if this works, or how to test it. I have ran the build and existing tests for the task, but haven't manually tested the task anywhere (and have no idea how anything here works...).