Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GulpV1] Migrated to Node10 #14195

Merged
merged 7 commits into from
Jan 19, 2021
Merged

[GulpV1] Migrated to Node10 #14195

merged 7 commits into from
Jan 19, 2021

Conversation

sdobrodeev
Copy link

Task name: GulpV1

Description: Migrated GulpV1 to Node 10 execution handler.

Documentation changes required: No

Added unit tests: No

Attached related issue: No

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@sdobrodeev sdobrodeev requested a review from a team January 8, 2021 09:45
@sdobrodeev sdobrodeev self-assigned this Jan 8, 2021
@sdobrodeev sdobrodeev requested a review from jtpetty as a code owner January 8, 2021 09:45
@anatolybolshakov anatolybolshakov requested a review from a team January 8, 2021 10:59
DaniilShmelev
DaniilShmelev approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@DaniilShmelev DaniilShmelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anatolybolshakov
Copy link
Contributor

Let's merge this after merging of related canary PR

@sdobrodeev sdobrodeev merged commit a53a321 into master Jan 19, 2021
@sdobrodeev sdobrodeev deleted the users/sdobrodeev/GulpV1-Node10-migration branch January 19, 2021 11:31
@anatolybolshakov anatolybolshakov mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

@DaniilShmelev DaniilShmelev DaniilShmelev approved these changes

@EzzhevNikita EzzhevNikita EzzhevNikita approved these changes

@jtpetty jtpetty Awaiting requested review from jtpetty

Assignees

@sdobrodeev sdobrodeev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdobrodeev @anatolybolshakov @EzzhevNikita @DaniilShmelev