Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed copy files for broken symlink case #13759

Merged
merged 10 commits into from
Oct 29, 2020
Merged

Fixed copy files for broken symlink case #13759

merged 10 commits into from
Oct 29, 2020

Conversation

anatolybolshakov
Copy link
Contributor

@anatolybolshakov anatolybolshakov commented Oct 23, 2020 •
edited
Loading

Task name: CopyFilesV2

Description:

  • There was an issue related to broken symlinks - if they present in source directory, but filtered by 'Content' pattern - task failed. As a solution - allowed broken symlinks in source directory.
  • Solved solution with timeout for CopyFilesV2 L0 tests

Documentation changes required: N

Added unit tests: Y

Attached related issue: #9046

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@anatolybolshakov anatolybolshakov requested a review from a team October 23, 2020 10:08
alexander-smolyakov
alexander-smolyakov approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please take a look at the comment.

Also, it seems that some unit-tests failed due to timeout exceeded. I suggest we can increase the timeout for them.

Thanks!

Tasks/CopyFilesV2/copyfiles.ts Outdated Show resolved Hide resolved
@anatolybolshakov anatolybolshakov mentioned this pull request Oct 23, 2020
Closed
@anatolybolshakov anatolybolshakov force-pushed the users/anatolybolshakov/fix9046_CopyFiles_symlink_issue branch from 7268b3d to 0b6065a Compare October 26, 2020 14:14
@anatolybolshakov anatolybolshakov force-pushed the users/anatolybolshakov/fix9046_CopyFiles_symlink_issue branch from 3fa1c76 to 12be6fe Compare October 27, 2020 09:53
@anatolybolshakov anatolybolshakov merged commit dc07aba into master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-bryzgalov egor-bryzgalov egor-bryzgalov approved these changes

@EzzhevNikita EzzhevNikita EzzhevNikita approved these changes

@alexander-smolyakov alexander-smolyakov alexander-smolyakov approved these changes

@mjroghelia mjroghelia Awaiting requested review from mjroghelia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anatolybolshakov @alexander-smolyakov @EzzhevNikita @egor-bryzgalov