-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InstallAppleProvisioningProfileV1] Migrated to Node10 #13730
Merged
egor-bryzgalov
merged 17 commits into
master
from
users/egor-bryzgalov/InstallAppleProvProfile-node14-migration
Nov 3, 2020
Merged
[InstallAppleProvisioningProfileV1] Migrated to Node10 #13730
egor-bryzgalov
merged 17 commits into
master
from
users/egor-bryzgalov/InstallAppleProvProfile-node14-migration
Nov 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-peck
reviewed
Oct 19, 2020
alex-peck
reviewed
Oct 19, 2020
DaniilShmelev
approved these changes
Oct 20, 2020
anatolybolshakov
approved these changes
Oct 20, 2020
EzzhevNikita
approved these changes
Oct 20, 2020
alex-peck
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
egor-bryzgalov
requested review from
anatolybolshakov,
alex-peck,
EzzhevNikita and
a team
November 2, 2020 18:06
alexander-smolyakov
approved these changes
Nov 2, 2020
egor-bryzgalov
changed the title
[InstallAppleProvisioningProfileV1] Migrated to Node14
[InstallAppleProvisioningProfileV1] Migrated to Node10
Nov 2, 2020
EzzhevNikita
approved these changes
Nov 2, 2020
alex-peck
approved these changes
Nov 2, 2020
…le-node14-migration
sdobrodeev
approved these changes
Nov 3, 2020
…le-node14-migration
egor-bryzgalov
deleted the
users/egor-bryzgalov/InstallAppleProvProfile-node14-migration
branch
November 3, 2020 07:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: InstallAppleProvisioningProfileV1
Description: Updated dependencies to prepare the task to be executed with Node 10.
This canary test is required before merging.
Documentation changes required: No
Added unit tests: No
Attached related issue: #299
Checklist: