Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update engineering infrastructure for Node 14 + Upgrade some tasks #13603

Merged
merged 20 commits into from
Sep 28, 2020

Conversation

alex-peck
Copy link
Contributor

@alex-peck alex-peck commented Sep 23, 2020

Allows tests to run on different node versions

Upgrades:

  • ArchiveFilesV1
  • BashV3
  • CmdLineV2
  • DeleteFilesV1
  • ExtractFilesV1

Tested tasks with this pipeline:

strategy:
  matrix:
    linux:
      imageName: 'ubuntu-16.04'
    mac:
      imageName: 'macos-10.14'
    windows:
      imageName: 'vs2017-win2016'

pool:
  vmImage: $(imageName)

steps:
- task: CmdLine@2
  inputs:
    script: echo Testing!
- task: CmdLine@2
  inputs:
    script: exit 1
  continueOnError: true
- task: Bash@3
  condition: ne(variables.imageName, 'vs2017-win2016')
  inputs:
    targetType: 'inline'
    script: echo Testing!
- task: Bash@3
  condition: ne(variables.imageName, 'vs2017-win2016')
  inputs:
    filePath: 'testscript.sh'
- task: Bash@3
  condition: ne(variables.imageName, 'vs2017-win2016')
  inputs:
    targetType: 'inline'
    script: exit 1
  continueOnError: true
- task: ExtractFiles@1
  inputs:
    archiveFilePatterns: 'Downloads.zip'
    destinationFolder: 'test'
    cleanDestinationFolder: true
- task: ExtractFiles@1
  inputs:
    archiveFilePatterns: 'Downloads.tar'
    destinationFolder: 'test2'
    cleanDestinationFolder: true
- task: ExtractFiles@1
  inputs:
    archiveFilePatterns: 'Downloads.tar.gz'
    destinationFolder: 'test3'
    cleanDestinationFolder: true
- script: ls -la test
- script: ls -la test2
- script: ls -la test3
- task: ArchiveFiles@2
  inputs:
    rootFolderOrFile: '$(Build.BinariesDirectory)'
    includeRootFolder: true
    archiveType: 'zip'
    archiveFile: '$(Build.ArtifactStagingDirectory)/$(Build.BuildId).zip'
    replaceExistingArchive: true
- task: ArchiveFiles@2
  inputs:
    rootFolderOrFile: '$(Build.BinariesDirectory)'
    includeRootFolder: true
    archiveType: 'tar'
    archiveFile: '$(Build.ArtifactStagingDirectory)/$(Build.BuildId).tar.gz'
    replaceExistingArchive: true
- task: DeleteFiles@1
  inputs:
    Contents: 'test'

@alex-peck alex-peck force-pushed the users/alpeck/node_14_tasks branch from f2824ce to 96ef1e4 Compare September 23, 2020 21:36
@alex-peck alex-peck marked this pull request as ready for review September 28, 2020 16:18
Tasks/BashV3/bash.ts Show resolved Hide resolved
make-util.js Show resolved Hide resolved
make.js Outdated Show resolved Hide resolved
make.js Show resolved Hide resolved
Copy link

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with these changes - I have a couple lingering comments from before, but I think they're mostly just opinions at this point

@alex-peck alex-peck merged commit 289e148 into master Sep 28, 2020
mjroghelia added a commit that referenced this pull request Oct 26, 2020
mjroghelia added a commit that referenced this pull request Oct 26, 2020
* Revert "Update versions. (#13765)"

This reverts commit 6c44d8c.

* Revert "Add min agent version. (#13764)"

This reverts commit c73b5df.

* Revert "[ExtractFilesV1] Add warning for when no archives were found (#13747)"

This reverts commit daf6d16.

* Revert "Block extra dev dependencies for now (#13731)"

This reverts commit 49de059.

* Revert "Fix test running in CI (#13628)"

This reverts commit 414c031.

* Revert "Update engineering infrastructure for Node 14 + Upgrade some tasks (#13603)"

This reverts commit 289e148.

* Bump the task versions

* Fix flaky DeleteFilesV1 test
mjroghelia added a commit that referenced this pull request Oct 26, 2020
* Revert "Update versions. (#13765)"

This reverts commit 6c44d8c.

* Revert "Add min agent version. (#13764)"

This reverts commit c73b5df.

* Revert "[ExtractFilesV1] Add warning for when no archives were found (#13747)"

This reverts commit daf6d16.

* Revert "Block extra dev dependencies for now (#13731)"

This reverts commit 49de059.

* Revert "Fix test running in CI (#13628)"

This reverts commit 414c031.

* Revert "Update engineering infrastructure for Node 14 + Upgrade some tasks (#13603)"

This reverts commit 289e148.

* Bump the task versions

* Fix flaky DeleteFilesV1 test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants