-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update engineering infrastructure for Node 14 + Upgrade some tasks #13603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-peck
force-pushed
the
users/alpeck/node_14_tasks
branch
from
September 23, 2020 21:36
f2824ce
to
96ef1e4
Compare
alex-peck
requested review from
damccorm,
jtpetty,
mjroghelia and
stephenmichaelf
as code owners
September 28, 2020 16:18
damccorm
reviewed
Sep 28, 2020
damccorm
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with these changes - I have a couple lingering comments from before, but I think they're mostly just opinions at this point
mjroghelia
added a commit
that referenced
this pull request
Oct 26, 2020
* Revert "Update versions. (#13765)" This reverts commit 6c44d8c. * Revert "Add min agent version. (#13764)" This reverts commit c73b5df. * Revert "[ExtractFilesV1] Add warning for when no archives were found (#13747)" This reverts commit daf6d16. * Revert "Block extra dev dependencies for now (#13731)" This reverts commit 49de059. * Revert "Fix test running in CI (#13628)" This reverts commit 414c031. * Revert "Update engineering infrastructure for Node 14 + Upgrade some tasks (#13603)" This reverts commit 289e148. * Bump the task versions * Fix flaky DeleteFilesV1 test
mjroghelia
added a commit
that referenced
this pull request
Oct 26, 2020
* Revert "Update versions. (#13765)" This reverts commit 6c44d8c. * Revert "Add min agent version. (#13764)" This reverts commit c73b5df. * Revert "[ExtractFilesV1] Add warning for when no archives were found (#13747)" This reverts commit daf6d16. * Revert "Block extra dev dependencies for now (#13731)" This reverts commit 49de059. * Revert "Fix test running in CI (#13628)" This reverts commit 414c031. * Revert "Update engineering infrastructure for Node 14 + Upgrade some tasks (#13603)" This reverts commit 289e148. * Bump the task versions * Fix flaky DeleteFilesV1 test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows tests to run on different node versions
Upgrades:
Tested tasks with this pipeline: