Extract Files task fails: not enough memory #13595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzzhevNikita
added
bug
Area: ABTT
EzzhevNikita
force-pushed
the
users/EzzhevNikita/extract-files-couldnt-allocate-memory
branch
from
97bd336 to
51c6e65
Compare
anton-erofeev
approved these changes
Sep 23, 2020
damccorm
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
LGTM.
2 notes though:
- Please make sure CI is passing before merging. Its currently broken due to an agent issue, but it should be back up by the end of the day.
- Could you name the commit something a little more descriptive of the change itself? (e.g. "Extract Files task: add overwrite option")
EzzhevNikita
force-pushed
the
users/EzzhevNikita/extract-files-couldnt-allocate-memory
branch
from
51c6e65 to
1dffd7e
Compare
EzzhevNikita
force-pushed
the
users/EzzhevNikita/extract-files-couldnt-allocate-memory
branch
from
1dffd7e to
9338930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: ExtractFiles
Description: Added support for content overwriting in output directory, using additional input parameter
#120
Feedback ticket
I applied some amendments to existing pr's that related to this issue and several related ones and created this one
Documentation changes required: (Y/N) Y
Added unit tests: (Y/N) Y
Attached related issue: (Y/N) Y
Related Issue 1
Related Issue 2
Related ps's:
Related PR 1
Related PR 2
Checklist: