Add second msdeploy instance in AzureRmWebAppDeploymentV3 #13567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damccorm
requested review from
chshrikh,
SumiranAgg and
Vijay-train
as code owners
20shivangi
reviewed
Sep 18, 2020
| "archiveName": "MSDeploy.zip", | ||
| "url": "https://vstsagenttools.blob.core.windows.net/tools/MSDeploy/3.6/MSDeploy.zip", | ||
| "dest": "./webdeployment-common/" | ||
| }, |
There was a problem hiding this comment.
I did not get your description. Why we need above line here where destination is ./ , it will be under webdeployment-common folder only, right ?
There was a problem hiding this comment.
That's what we had before my change broke this. So I assume there are instances of the task relying on MSDeploy being in the root folder as well as in webdeployment-common
There was a problem hiding this comment.
Okay, we can go with this for now then to unblock customer
|
@aksm-ms Please you also review this PR since you have more context of this task. |
20shivangi
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureRmWebAppDeploymentV3
Description: This change copies the MSDeploy executable into the webdeployment-common folder. This introduces 2 instances of this executable, which is apparently what we previously had - the owning team should follow up with a pr to fix that since this is definitely redundant.
Documentation changes required: N
Added unit tests: N
Attached related issue: Y - Fixes #13566
Checklist: