Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish removing azure-arm-rest-v2 #13500

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Conversation

damccorm
Copy link

@damccorm damccorm commented Sep 2, 2020

Description: Finish moving azure-arm-rest-v2 to shared npm package instead of common folder. Source code

Documentation changes required: N

Added unit tests: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@@ -4,7 +4,7 @@
"@types/mocha": "2.2.48",
"@types/node": "6.0.68",
"@types/q": "1.0.7",
"azure-arm-rest-v2": "file:../../_build/Tasks/Common/azure-arm-rest-v2-2.0.0.tgz",
"azure-pipelines-tasks-azure-arm-rest-v2": "1.0.2",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 1.0.2 because the original published version had some TS files in it. Its not a big deal and wouldn't have functional impact, but was causing a compile error on one of the tasks.

@damccorm damccorm merged commit a5d93b6 into master Sep 2, 2020
@damccorm damccorm deleted the users/damccorm/azure-arm-rest-v2 branch September 2, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants