Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove azure-blobstorage-artifactProvider common package #13492

Merged
merged 9 commits into from
Sep 2, 2020

Conversation

damccorm
Copy link

@damccorm damccorm commented Sep 1, 2020

Description: Move azure-blobstorage-artifactProvider into the Jenkins task which is the only consumer (outside of the JavaToolInstaller which had a dead reference to it in a test)

Documentation changes required: N

Added unit tests: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@stephenmichaelf
Copy link
Member

Missing bump of task.json and task.loc.json.

@bishal-pdMSFT
Copy link
Contributor

@damccorm this common module is also used in AzureVmssDeployment task and that will break.

"module": "../Common/azure-blobstorage-artifactProvider-v2",

@damccorm
Copy link
Author

damccorm commented Sep 1, 2020

@bishal-pdMSFT that is azure-blobstorage-artifactProvider-v2, not just azure-blobstorage-artifactProvider. They're different packages

@bishal-pdMSFT
Copy link
Contributor

bishal-pdMSFT commented Sep 1, 2020 via email

@damccorm damccorm merged commit 9f6d532 into master Sep 2, 2020
@damccorm damccorm deleted the users/damccorm/blobstorage branch September 2, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants