Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamariniOSV2] Delete vsts-task-lib from package-lock.json #13363

Conversation

alexander-smolyakov
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov commented Jul 28, 2020

Task name: XamariniOSV2

Description:
Since the related task migrated to azure-pipelines-task-lib there is no need to keep vsts-task-lib in lock-file.

Documentation changes required: No

Added unit tests: No

Attached related issue:

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Note:
I increased timeouts on some unit tests. Since there was an issue related to macOS checks and unit tests fails with this error:
Error: timeout of *ms exceeded. Ensure the done() callback is being called in this test.

Aleksandr Smolyakov added 2 commits July 28, 2020 13:59
* Remove the vsts-task-lib from package-lock.json
@alexander-smolyakov alexander-smolyakov requested review from a team July 28, 2020 12:43
@alexander-smolyakov alexander-smolyakov self-assigned this Jul 28, 2020
@alexander-smolyakov alexander-smolyakov merged commit 9fb8d3e into master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants