Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InstallSSHKeyV0] Added config editing #13340

Merged

Conversation

egor-bryzgalov
Copy link
Member

@egor-bryzgalov egor-bryzgalov commented Jul 23, 2020

Task name: InstallSSHKeyV0

Description:

  • Feature was Implemented which allows to add entry to SSH config file. It can be useful for storing different SSH options for each remote server.
  • Changed known_hosts handling behavior. Entries will be appended if the task is invoked multiple times instead of overwriting the whole file.
  • Public key file is now created to avoid errors while deleting keys from agent in the post-job step.

Documentation changes required: (Y/N) Yes

Added unit tests: (Y/N) No

Attached related issue: (Y/N) #13283

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@egor-bryzgalov egor-bryzgalov requested a review from a team July 23, 2020 13:55
@egor-bryzgalov egor-bryzgalov self-assigned this Jul 23, 2020
@egor-bryzgalov egor-bryzgalov requested a review from damccorm July 23, 2020 13:58
Copy link

@sdobrodeev sdobrodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@egor-bryzgalov egor-bryzgalov merged commit e108198 into master Jul 28, 2020
@egor-bryzgalov egor-bryzgalov deleted the users/egor-bryzgalov/InstallSSHKeyV0-added-config-editor branch November 11, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants