Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing process scope #13336

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Removing process scope #13336

merged 1 commit into from
Jul 23, 2020

Conversation

20shivangi
Copy link
Contributor

Task name: AzurePowerShellV4/V5

Description: Removing process scope from set-azcontext

@bergmeister
Copy link
Contributor

bergmeister commented Jul 28, 2020

I see this is a revert of #13336 , which caused PSJobs to inherit the authentication any more. Can you please prioritise the rollout of those new task versions @20shivangi @chshrikh @buckh as pipelines have been broken for several days now due to that.

@chshrikh
Copy link
Contributor

@bergmeister sorry for the inconvenience, the roll back fix deployment is in-progress, it should get deployed in 3-4 days to all rings

@bergmeister
Copy link
Contributor

@chshrikh Thank you for the update. However, I think 3-4 days are a very long time for a simple rollback that does not conflate with other changes, especially given that the bug has been in production for several days now. The impact is quite severe because for example existing scripts that use Az cmdlets in PowerShell Jobs are completely broken and according to issue #13329 it even seems that some cmdlets like Switch-AzWebAppSlot are broken because of that, that heavily affect production.
I understand why you want to have a slow ring deployment rollout concept but when it comes to a rollback just the last change, I do not see it as necessary to go through the same procedure and would warrant an expedited deployment. The whole concept of DevOps is to deploy often and in small amounts (which you do) but if things go wrong, then one also needs to be quick to rollback quickly, which I do not see. I would be an understanding if a rollback would also mean other changes would get rolled back but in this instance, it is a rollback of a single change that should be expedited.

@bergmeister
Copy link
Contributor

bergmeister commented Jul 30, 2020

@chshrikh I can see, the patched versions got deployed this morning, many thanks for expediting the rollback 😀
Please make sure there are regression test for this, especially using PowerShell jobs (which are process based) in the AzurePowerShell tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants