Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JenkinsQueueJobV2] Improved error handling #13242

Conversation

egor-bryzgalov
Copy link
Member

Task name: JenkinsQueueJobV2

Description:

  • Improved error handling to show the body of HTTP response

  • Fixed test

Documentation changes required: No

Added unit tests: No

Attached related issue: #12543

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@egor-bryzgalov egor-bryzgalov requested a review from a team July 7, 2020 06:53
@egor-bryzgalov egor-bryzgalov requested a review from leantk as a code owner July 7, 2020 06:53
@egor-bryzgalov egor-bryzgalov self-assigned this Jul 7, 2020
@egor-bryzgalov egor-bryzgalov requested review from damccorm and a team July 7, 2020 13:24
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egor-bryzgalov egor-bryzgalov merged commit cbad58b into master Jul 13, 2020
@egor-bryzgalov egor-bryzgalov deleted the users/egor-bryzgalov/fix12543-JenkinsQueueJobV2-improved_error_handling branch July 13, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants