[JavaToolInstaller]. Handling for 'unknown' errors #13237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasks/JavaToolInstallerV0/task.json
Outdated
| @@ -177,6 +177,7 @@ | |||
| "CorrelationIdForARM": "Correlation ID from ARM api call response : %s", | |||
| "JavaNotPreinstalled": "Java %s is not preinstalled on this agent", | |||
| "UsePreinstalledJava": "Use preinstalled JDK from %s", | |||
| "WrongArchiveStructure": "JDK file is not valid. Verify if JDK file contains only one root folder with 'bin' inside." | |||
| "WrongArchiveStructure": "JDK file is not valid. Verify if JDK file contains only one root folder with 'bin' inside.", | |||
| "ShareAccessError": "Network shared resource not available (%s)" | |||
There was a problem hiding this comment.
Nit: 'Network shared resource not available: (%s)'
anatolybolshakov
suggested changes
Jul 6, 2020
sdobrodeev
force-pushed
the
users/sdobrodeev/bug13006_JavaToolInstaller_unknown_error
branch
from
9202eb4 to
09b1fad
Compare
| @@ -11,6 +11,7 @@ interface IDirectoriesDictionary { | |||
| } | |||
|
|
|||
| export class JavaFilesExtractor { | |||
| readonly ERR_SHARE_ACCESS = -4094; | |||
There was a problem hiding this comment.
Could it be private instead of public?
sdobrodeev
force-pushed
the
users/sdobrodeev/bug13006_JavaToolInstaller_unknown_error
branch
from
09b1fad to
ba07852
Compare
sdobrodeev
deleted the
users/sdobrodeev/bug13006_JavaToolInstaller_unknown_error
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: JavaToolInstaller
Description: Added handling for an error that occurs when calling a
statmethod for an inaccessible Windows share.Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) #13006 and #12200
Checklist: