Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running commands silently #13189

Merged
merged 8 commits into from
Jun 29, 2020
Merged

Conversation

shigupt202
Copy link
Contributor

Task name: HelmDeployV0

Description: Running helm get manifest and kubectl get pods -o json silently to avoid revealing secrets and lengthy logs

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) (Updated)

Attached related issue: (Y/N) #13175

Checklist:
✔️ Task version was bumped - please check instruction how to do it
✔️ Checked that applied changes work as expected

@shigupt202 shigupt202 requested a review from thesattiraju June 26, 2020 14:25
@shigupt202 shigupt202 requested a review from ammohant as a code owner June 26, 2020 14:25
Copy link
Contributor

@thesattiraju thesattiraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tasks/HelmDeployV0/task.loc.json Outdated Show resolved Hide resolved
@shigupt202 shigupt202 force-pushed the users/shigupt/runHelmCommandsSilently branch from e3e0e56 to a465448 Compare June 29, 2020 10:12
@shigupt202 shigupt202 merged commit 0ee6c8f into master Jun 29, 2020
@shigupt202 shigupt202 deleted the users/shigupt/runHelmCommandsSilently branch June 29, 2020 14:08
@vaclavbroz
Copy link

Now the helm task will run kubectl cluster-info which will result in a forbidden warning because cluster-info may not be accessible for the given service connection, e.g. Error from server (Forbidden): services is forbidden: User "system:serviceaccount:xxx-sa:xxx cannot list resource "services" in API group "" in the namespace "kube-system"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants