Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CopyFilesOverSSHV0] Replaced bash command by sh #13105

Merged
merged 2 commits into from
Jun 15, 2020
Merged

[CopyFilesOverSSHV0] Replaced bash command by sh #13105

merged 2 commits into from
Jun 15, 2020

Conversation

egor-bryzgalov
Copy link
Member

Task name: CopyFilesOverSSHV0

Description: Replaced bash with sh at the 'Clean target folder' command to improve compatibility.

Documentation changes required: (Y/N) No

Added unit tests: (Y/N) No

Attached related issue: (Y/N) No

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@egor-bryzgalov egor-bryzgalov requested a review from a team June 11, 2020 08:45
anatolybolshakov
anatolybolshakov approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@johan-ejstrud johan-ejstrud mentioned this pull request Jun 15, 2020
Closed
@egor-bryzgalov egor-bryzgalov requested a review from damccorm June 15, 2020 07:10
@egor-bryzgalov egor-bryzgalov requested a review from leantk June 15, 2020 11:54
@egor-bryzgalov egor-bryzgalov merged commit 30ec047 into master Jun 15, 2020
@egor-bryzgalov egor-bryzgalov deleted the users/egor-bryzgalov/CopyOverSSH-clean-target-folder-enhancement branch June 15, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damccorm damccorm damccorm approved these changes

@anton-erofeev anton-erofeev anton-erofeev approved these changes

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

@zachariahcox zachariahcox Awaiting requested review from zachariahcox

@leantk leantk Awaiting requested review from leantk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@egor-bryzgalov @anatolybolshakov @anton-erofeev @damccorm