[AzureFileCopy] Pick up latest Azure PowerShell module on Hosted agent #13067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted agent environment
…r not to update env:psmodulepath
asranja
reviewed
Jun 8, 2020
| @@ -17,7 +17,7 @@ | |||
| "version": { | |||
| "Major": 1, | |||
| "Minor": 167, | |||
There was a problem hiding this comment.
Please update the minor version to the current sprint number.
asranja
reviewed
Jun 8, 2020
| @@ -0,0 +1,27 @@ | |||
| function Get-EndpointAuthenticationScheme | |||
There was a problem hiding this comment.
Do we still need this utility ?
asranja
reviewed
Jun 8, 2020
| @@ -17,7 +17,7 @@ | |||
| "version": { | |||
There was a problem hiding this comment.
Are we currently fixing this for AzureCloudPowerShellDeployment task as well ?
asranja
reviewed
Jun 8, 2020
Tasks/AzureFileCopyV2/task.json
Outdated
| @@ -14,7 +14,7 @@ | |||
| "version": { | |||
| "Major": 2, | |||
| "Minor": 167, | |||
There was a problem hiding this comment.
Please update the minor version to the current sprint number.
asranja
reviewed
Jun 8, 2020
Tasks/AzureFileCopyV3/task.json
Outdated
| @@ -14,7 +14,7 @@ | |||
| "version": { | |||
| "Major": 3, | |||
| "Minor": 167, | |||
There was a problem hiding this comment.
Please update the minor version to the current sprint number.
asranja
reviewed
Jun 8, 2020
| Write-Verbose "Latest AzureRM module path is null or empty." | ||
| } | ||
| } | ||
|
|
asranja
reviewed
Jun 8, 2020
| @@ -65,6 +65,8 @@ Import-Module $PSScriptRoot\ps_modules\RemoteDeployer | |||
|
|
|||
| # Initialize Azure. | |||
| Import-Module $PSScriptRoot\ps_modules\VstsAzureHelpers_ | |||
| $endpoint = Get-Endpoint -connectedServiceName $connectedServiceName | |||
| Update-PSModulePathForHostedAgentWithLatestModule -Endpoint $endpoint | |||
There was a problem hiding this comment.
Please move the line . "$PSScriptRoot\Utility.ps1" before the Get-Endpoint call
asranja
approved these changes
Jun 8, 2020
asranja
changed the title
asranja
added a commit
that referenced
this pull request
Jun 8, 2020
#13067) * update azure file copy to use latest available azure rm module on hosted agent environment * update task version * check for null for latestazurermmodulepath * move psmoduleutility to common. afcv2 and afcv3 * refactor out get-endpointauthenticationscheme function * use endpoint.type instead of authentication scheme to check whether or not to update env:psmodulepath * update task version of tasks using common modules dependency * remove endpoint utility as it is not needed * load utility.ps1 before calling get-endpoint * update minor version Co-authored-by: Ashish Ranjan 💩 <asranja@microsoft.com>
asranja
added a commit
that referenced
this pull request
Jun 9, 2020
#13067) (#13083) * update azure file copy to use latest available azure rm module on hosted agent environment * update task version * check for null for latestazurermmodulepath * move psmoduleutility to common. afcv2 and afcv3 * refactor out get-endpointauthenticationscheme function * use endpoint.type instead of authentication scheme to check whether or not to update env:psmodulepath * update task version of tasks using common modules dependency * remove endpoint utility as it is not needed * load utility.ps1 before calling get-endpoint * update minor version Co-authored-by: Ashish Ranjan 💩 <asranja@microsoft.com> Co-authored-by: Arjun Gupta <arjgupta@microsoft.com>
asranja
added a commit
that referenced
this pull request
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.