Update preinstallprovprofile.ts

[jmartarelli]

To keep macOS (OSX) App compatibility (Developer ID Application)

https://developer.apple.com/developer-id/
https://fileinfo.com/extension/provisionprofile

.mobileprovision - iOS provisioning profile
.provisionprofile - OSX provisioning profile

Fixes #13045

[leantk]

@anatolybolshakov can we get somebody to take a look at this please? It LGTM except for the version bump that is missing

[leantk]

@jmartarelli thanks so much for the contribution! 🎉

Could you make 2 minor adjustments please? The version of the task needs updated so that the changes get picked up. If you go to the task.json and task.loc.json files for this task, you will see a major/minor/patch version. Can you change the patch version to 0 and the minor version to 171 please (this matches our sprint cadence). You can see an example of this here (but only needed for this task and not others): fe7dd46#diff-c73ecd0ae1d53f810bd8fad2a95b0b84

[anatolybolshakov]

LGTM, thanks for contribution!

[jmartarelli]

@jmartarelli thanks so much for the contribution! 🎉

Could you make 2 minor adjustments please? The version of the task needs updated so that the changes get picked up. If you go to the task.json and task.loc.json files for this task, you will see a major/minor/patch version. Can you change the patch version to 0 and the minor version to 171 please (this matches our sprint cadence). You can see an example of this here (but only needed for this task and not others): fe7dd46#diff-c73ecd0ae1d53f810bd8fad2a95b0b84

Yes, sure. I will make the adjustments you mentioned!

[ghost]

All CLA requirements met.

[jmartarelli]

I was asked to use this version (Minor: 171 and Patch: 0)

[leantk]

Thanks again @jmartarelli!

[jmartarelli]

Thanks again @jmartarelli!

@leantk , should we fix the Test classes as well?

• Tasks/InstallAppleProvisioningProfileV1/Tests/L0.ts 
• Tasks/InstallAppleProvisioningProfileV1/Tests/L0SecureFile.ts

There are ".mobileprovision" extension verification on these classes above...

[leantk]

@jmartarelli good call. If you have a moment to do that then great but otherwise I'll put it on our backlog to add them

[brewmanandi]

We are running into this. Any way to circumvent ATM?

[nor0x]

any updates on this? our pipeline still fails for macOS builds

[leantk]

This should be deployed starting next week. I don't have a workaround but @anatolybolshakov if you have any ideas

[anatolybolshakov]

Yes, basically, as a fast fix to avoid this validation - changing extension to .mobileprovision could work, this task uses 'security cms' call inside, and it doesn't seem to consider file extension... @anton-erofeev could you please check it?

[nor0x]

@anatolybolshakov renaming is not a solution. the task runs fine with this workaround but the build / signing process doesn't pick up the profile. Building a macOS project still fails in my pipeline:

/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Mac/Xamarin.Mac.Common.targets(464,3): error : The specified macOS provisioning profile 'profile-name' could not be found

[anton-erofeev]

Hi, @nor0x
Did you change the extension of the real file and upload it or change the secure file name in your azure devops library?

[nor0x]

Hey @anton-erofeev,
i have changed the real filename and uploaded it to the pipeline.

EDIT: also tried changing the details in the azure devops library, which doesn't work for me

[anton-erofeev]

@nor0x Have you tried to download the original file, but change the file name in the Secure files list? (for example: someName.mobileprovision)

[nor0x]

@anton-erofeev yes i have tried this as well - no luck for now

[anatolybolshakov]

Thanks @nor0x 👍
@brewmanandi @nor0x @jmartarelli Just as another option - I prepared task package with these changes (InstallAppleProvisioningProfileV1.zip), and it can be uploaded to your organization by following these instructions https://github.com/Microsoft/tfs-cli/blob/HEAD/docs/buildtasks.md#upload - this is a workaround, but it could unblock you....
Please ping me for any questions

[jmartarelli]

@nor0x, @brewmanandi

There is a workaround for this: Instead of getting the certificate (".provisionprofile") uploaded into azure, put it somewhere inside your source branch and configure the task to look into your source repository... (There is a combo box for this option selection on the task)...

[nor0x]

thank you @jmartarelli works fine for me!

[firaxis]

Hi!
When updated task will be rolled out ?

[anatolybolshakov]

Hi @firaxis, it will be rolled out during next 2-3 weeks

[firaxis]

It's pity that you can't roll out a hotfix..
Fortunately, uploading a fixed task is quite simple, thanks :)

@anatolybolshakov Could you please tell, after next release, do I need to do anything to keep task updating further ?

[anatolybolshakov]

@firaxis no, you don't need to do anything - it will be just updated automatically