-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JenkinsQueueJobV2] Fix job hang out after unexpected response from Jenkins #13034
Merged
alexander-smolyakov
merged 8 commits into
master
from
users/alexander-smolyakov/issue12869_JenkinsQueueJobV2_fix_job_waiting
Jun 1, 2020
Merged
[JenkinsQueueJobV2] Fix job hang out after unexpected response from Jenkins #13034
alexander-smolyakov
merged 8 commits into
master
from
users/alexander-smolyakov/issue12869_JenkinsQueueJobV2_fix_job_waiting
Jun 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Export JobState enum * Export logics for job state transitions validation into a separate function * Add unit test for checking job state transitions
* Refactor the function for state transitions validation * Add new unit test for testing state transition * Refactor the "DoWork" method from Job class
* Add new status for job * Add stop when we get unexcpectd response from Jenkins on finishing state * Fix link on the task
* Rewrite commentaries for job states on JSdoc * Refactor the "getFullErrorMessage" function * Modify log-message for killed jobs
* Change the title of the test on more clear * Fixed typo in the test title
alexander-smolyakov
requested review from
sergey-akhalkov,
anatolybolshakov and
a team
May 29, 2020 07:38
anatolybolshakov
approved these changes
May 29, 2020
anton-erofeev
approved these changes
May 29, 2020
Nice refactor 👍 |
leantk
approved these changes
May 29, 2020
egor-bryzgalov
approved these changes
Jun 1, 2020
…nsQueueJobV2_fix_job_waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fix #9 and applying the following changes:
Fixes
About this task
link, previously it redirects on Jenkins site instead of docs.microsoft.comCode refactor
checkStateTransitions
JobState
enum andcheckStateTransitions
function was exported into a separate module and refactored.DoWork
method from theJob
class. Theif-else
was replaced onswitch
.statusCode
type documented asnumber
. So it's safe to use Strict Equals Operator.)Unit tests
Testing