Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing workingDirectory not honored for .NET Core task build #13010

Merged
merged 19 commits into from
Jun 18, 2020

Conversation

issacnitin
Copy link
Contributor

@issacnitin issacnitin commented May 27, 2020

Fixing issues #12717 and #10996 for dotnet restore and build

Root cause is that while searching for project files, workingDirectory input is not considered

@issacnitin issacnitin requested a review from bishal-pdMSFT as a code owner May 27, 2020 14:05
@bishal-pdMSFT
Copy link
Contributor

@issacnitin can please link the issue and a short description of the root cause and the fix

@bishal-pdMSFT
Copy link
Contributor

bishal-pdMSFT commented May 29, 2020

@issacnitin I am not completely sure whether to need to "fix" this. IMO this is not really an issue. Minimatch pattern in projects input will allow user to select projects under a specific directory. The workingDirectory input is not required for that.
workingDirectory is used when running dotnet.exe commands. And that is being honored correctly. If we look at the input's markdown, it does state that this path used when running script.

Also, IMO this is a breaking change and it might start breaking existing customers.

@bishal-pdMSFT bishal-pdMSFT requested a review from tejasd1990 May 29, 2020 19:24
@bishal-pdMSFT
Copy link
Contributor

@tejasd1990 your opinion please!

@issacnitin
Copy link
Contributor Author

@bishal-pdMSFT If you feel this is not an issue, please close the associated github items. I’m surprised the items has been open for so long no action was taken to close it as it don’t need the fix.

Yes this is potentially a breaking change

@issacnitin issacnitin merged commit fcf2a84 into master Jun 18, 2020
@mhudasch
Copy link

mhudasch commented Dec 1, 2021

Hi, I just lost multiple days in development time because the documentation of the task does not mention the behavior of the projects matcher ignoring the working directory. It has very little to no use to only fix or extend the help tooltip of this problem when one is not using the settings ui of this task. A part of being able to edit the build pipelines using yaml in any editor is that this help is not available especially when one is editing the task deep down in another repository inside a pipeline template.
I would really urge you to update the online documentation of this task and close all related issues like #9789 and #10996 and clearly communicate your intentions with the workingDirectory parameter. This shrug of a comment is the only place that i could find (including sifting through the codebase) that mentions the current stance. Sorry for the rant but this was really frustrating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants