-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing workingDirectory not honored for .NET Core task build #13010
Conversation
@issacnitin can please link the issue and a short description of the root cause and the fix |
@issacnitin I am not completely sure whether to need to "fix" this. IMO this is not really an issue. Minimatch pattern in Also, IMO this is a breaking change and it might start breaking existing customers. |
@tejasd1990 your opinion please! |
@bishal-pdMSFT If you feel this is not an issue, please close the associated github items. I’m surprised the items has been open for so long no action was taken to close it as it don’t need the fix. Yes this is potentially a breaking change |
This reverts commit 9a8378b.
This reverts commit d955d52.
This reverts commit f1819f2.
…crosoft/azure-pipelines-tasks into users/nijoy/netcorecli_bugfix
…crosoft/azure-pipelines-tasks into users/nijoy/netcorecli_bugfix
Tasks/DotNetCoreCLIV2/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
Hi, I just lost multiple days in development time because the documentation of the task does not mention the behavior of the projects matcher ignoring the working directory. It has very little to no use to only fix or extend the help tooltip of this problem when one is not using the settings ui of this task. A part of being able to edit the build pipelines using yaml in any editor is that this help is not available especially when one is editing the task deep down in another repository inside a pipeline template. |
Fixing issues #12717 and #10996 for dotnet restore and build
Root cause is that while searching for project files, workingDirectory input is not considered