Creating Blob if not there #12826
Merged
Creating Blob if not there #12826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20shivangi
force-pushed
the
users/shmittal/CreatingBlob
branch
from
9224428 to
c12dbaf
Compare
arjgupta
reviewed
May 11, 2020
| $containerPresent = Get-AzureContainer -containerName $containerName -storageContext $storageContext | ||
|
|
||
| #creating container if the containerName provided does not exist | ||
| if([string]::IsNullOrEmpty($containerPresent) ) |
There was a problem hiding this comment.
since container is an object, this shouldn't be a string empty check, rather it should be a null check
arjgupta
reviewed
May 11, 2020
| #creating container if the containerName provided does not exist | ||
| if([string]::IsNullOrEmpty($containerPresent) ) | ||
| { | ||
| Create-AzureContainer -containerName $containerName -storageContext $storageContext -isPremiumStorage $isPremiumStorage |
arjgupta
reviewed
May 11, 2020
| @@ -92,9 +93,10 @@ $AzureFileCopyRemoteJob = { | |||
| $additionalArguments = "--recursive --log-level=INFO" | |||
| } | |||
|
|
|||
| Write-DetailLogs "##[command] & azcopy copy `"$containerURL*****`" `"$targetPath`" $additionalArguments" | |||
| $azCopyExeLocation = Join-Path -Path $azCopyFolderPath -ChildPath "AzCopy\AzCopy.exe" | |||
| Write-DetailLogs "##[command] & `"$azCopyExeLocation`" copy `"$containerURL*****`" `"$targetPath`" $additionalArguments" | |||
There was a problem hiding this comment.
use get-command to get the azcopy.exe command here. then use push-location and pop-location to execute the command
20shivangi
force-pushed
the
users/shmittal/CreatingBlob
branch
from
d1e8428 to
1c5e27e
Compare
arjgupta
reviewed
May 11, 2020
| @@ -118,8 +118,22 @@ try { | |||
| if([string]::IsNullOrEmpty($containerName) -or ($destination -ne "AzureBlob")) | |||
| { | |||
| $containerName = [guid]::NewGuid().ToString() | |||
| Create-AzureContainer -containerName $containerName -storageContext $storageContext -isPremiumStorage $isPremiumStorage | |||
| Write-Verbose "Creating temporary container for uploading files if no input is provided for container name" | |||
There was a problem hiding this comment.
this should be: Container Name input not found. Creating Temporary container for uploading files.
arjgupta
reviewed
May 11, 2020
| [Environment]::SetEnvironmentVariable("Path", $azCopyFolderEnvPath + ';' + $env:Path, [System.EnvironmentVariableTarget]::Machine) | ||
|
|
||
| #setting $env:Path to include azcopy.exe path as the above command used to set path at machine level takes some time to update the path environment variable |
There was a problem hiding this comment.
no don't say it takes some time. What is happening here is that once the task process initiates, the $env:path variable is set. The path variable here is the user path variable. So after you set the path variable at machine level, the user path variable remains the same. Please update the comment to reflect this idea accurately.
20shivangi
force-pushed
the
users/shmittal/CreatingBlob
branch
from
8c7a7b0 to
dd20186
Compare
arjgupta
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12827