Changed JS replace function from string to regex version where needed #12508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch should actually be global replacements, to global replacements (regex replacement). This is due to a quirks in javascript which is often overlooked: pure string replacements will only replace the FIRST occurrence of the string. However, most of the time you want to replace all occurences. For this you need to use the regex version of the javascript replace function. So I changed the string-replacements to regex-replacements where every occurence of a string should be replaced.
|
|
echalone
requested review from
ajinkya599,
Anumita,
navin22 and
prebansa
as code owners
|
I think the windows build died for some reason... it seems other pull requests have the same problem. Hope you're still seeing our pull requests, although those checks weren't "successful" ;) |
damccorm
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed single-time javascript replacements (string version of Javascript replace function), which should actually be global replacements, to global replacements (regex version of Javascript replace function).
This is due to a quirks in javascript which is often overlooked: pure string replacements will only replace the FIRST occurrence of the string. However, most of the time you want to replace all occurences. For this you need to use the regex version of the javascript replace function. So I changed the string-replacements to regex-replacements where every occurence of a string should be replaced.