Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DownloadPackage to support latest version #12334

Conversation

evertonmc
Copy link
Contributor

Fixes #12333
I've added a 'latest version resolver' to select the current package at runtime.

  • resolve if input version is latest
  • Support latest from view
  • added info at helpMarkDown

@joaquin386
Copy link

Very useful new feature. Right now have to do some hacking around to get it working with a 'latest' like behaviour.

@evertonmc
Copy link
Contributor Author

gently pinging reviewers @aasim @phil-hodgson @shubham90 @satbai @20shivangi

@VOVELEE
Copy link

VOVELEE commented May 14, 2020

Hi guys,

do you expect this functionality to be reviewed soon? It will greatly help for a use-case I am developing.

@gogbg
Copy link

gogbg commented May 14, 2020

This is a very important functionality for my use case. Please make it so.

@VOVELEE
Copy link

VOVELEE commented May 15, 2020

gently pinging reviewers @aasim @phil-hodgson @shubham90 @satbai @20shivangi

@ChrisGibson1982
Copy link

Hi Guys, has these been any progress on this? @aasim @phil-hodgson @shubham90 @satbai @20shivangi

Copy link
Contributor

@satbai satbai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. @aasim could you also have a look, as you've worked on this task before. Sorry for the delay on reviewing this.

@ghost
Copy link

ghost commented Sep 8, 2020

Can someone please resolve the remaining conflicts so the merge can be completed! This feature is fundamental for situations where npm is used to deploy custom build tools that are maintained. Not having to manually update ALL pipelines that are dependent on the latest version of a package would make my day so much nicer!

Copy link
Member

@aasim aasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evertonmc can you update the task version please?

Tasks/DownloadPackageV1/task.json Outdated Show resolved Hide resolved
@evertonmc
Copy link
Contributor Author

@aasim Done

@phil-hodgson phil-hodgson merged commit 4e6e65e into microsoft:master Sep 10, 2020
@ghost
Copy link

ghost commented Sep 10, 2020

Cool stuff, thanks for the quick resolution! I'm still new to this, when can I expect the change to take effect?

@VOVELEE
Copy link

VOVELEE commented Sep 15, 2020

When can we expect this change to be released?

@satbai
Copy link
Contributor

satbai commented Sep 15, 2020

It's impossible to give an exact date, but as a rough estimate, you should start seeing the change within the first weeks of October.

@evertonmc evertonmc deleted the feature/DownloadPackageV1-latest-selector branch October 17, 2020 10:02
@jfichtner
Copy link

I assume this should be active now? I'm getting an error when I set version to "latest" on a universal package feed.

@ghost
Copy link

ghost commented Aug 25, 2021

It works on my pipeline!

@jfichtner
Copy link

It works on my pipeline!

Thanks for the reply, but can I ask is it an option in the dropdown, or do you have to manually type it in? Because for me there is no option in the dropdown, and when I type in "latest" (as suggested by the tooltip) I get an error when it runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DownloadPackage doesn't support latest version
9 participants