Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new task to download GitHub packages #12292

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

romil07
Copy link
Contributor

@romil07 romil07 commented Feb 4, 2020

No description provided.

@romil07 romil07 requested a review from kasubram February 4, 2020 12:59
@romil07 romil07 force-pushed the users/rogoyal/GitHubPackages branch from 61a928b to 491ed83 Compare February 6, 2020 08:15
@romil07 romil07 force-pushed the users/rogoyal/GitHubPackages branch 2 times, most recently from 9c7d7d8 to 4360caf Compare February 26, 2020 10:36
@romil07 romil07 force-pushed the users/rogoyal/GitHubPackages branch from 4360caf to 2890718 Compare February 28, 2020 05:29
Tasks/DotnetCLIRestore/restorecommand.ts Outdated Show resolved Hide resolved
Tasks/DotnetCLIRestore/restorecommand.ts Outdated Show resolved Hide resolved
Tasks/DotnetCLIRestore/restorecommand.ts Outdated Show resolved Hide resolved
Tasks/DotnetCLIRestore/restorecommand.ts Outdated Show resolved Hide resolved
Tasks/DotnetCLIRestore/restorecommand.ts Outdated Show resolved Hide resolved
Tasks/DotnetCLIRestore/restorecommand.ts Outdated Show resolved Hide resolved
Tasks/DotnetCLIRestore/restorecommand.ts Outdated Show resolved Hide resolved
Tasks/Common/packaging-common/nuget/NuGetConfigHelper2.ts Outdated Show resolved Hide resolved
@romil07 romil07 force-pushed the users/rogoyal/GitHubPackages branch 2 times, most recently from 12010ac to 9d06e0c Compare March 3, 2020 09:28
Tasks/DotnetCLIRestore/restorecommand.ts Outdated Show resolved Hide resolved
Tasks/DotnetCLIRestore/restorecommand.ts Outdated Show resolved Hide resolved
@romil07 romil07 force-pushed the users/rogoyal/GitHubPackages branch 2 times, most recently from f233daa to dcf59c8 Compare March 11, 2020 11:29
@romil07 romil07 force-pushed the users/rogoyal/GitHubPackages branch 3 times, most recently from a23b17d to 307cd56 Compare March 11, 2020 11:54
}
finally {
if (!MessagePrinted) {
console.log(tl.loc('NetCore3Update'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to print this message as we are internally deciding .net core version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from CLIV2 task. If you think it shouldn't be displayed, I will remove it. Let me know.

@romil07 romil07 force-pushed the users/rogoyal/GitHubPackages branch 2 times, most recently from fc6f567 to c35eb3d Compare March 19, 2020 11:41
@romil07 romil07 force-pushed the users/rogoyal/GitHubPackages branch from c35eb3d to b595b9c Compare March 19, 2020 11:48
@romil07 romil07 merged commit 6020ac3 into master Mar 19, 2020
let credCleanup = () => { return; };

const sources: Array<auth.IPackageSource> = new Array<auth.IPackageSource>();
let feedUri: string = "https://nuget.pkg.github.com/" + username + "/index.json";
Copy link

@admin-simeon admin-simeon Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just bad logic for determining the feed url....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants