-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new task to download GitHub packages #12292
Conversation
61a928b
to
491ed83
Compare
9c7d7d8
to
4360caf
Compare
4360caf
to
2890718
Compare
12010ac
to
9d06e0c
Compare
f233daa
to
dcf59c8
Compare
a23b17d
to
307cd56
Compare
} | ||
finally { | ||
if (!MessagePrinted) { | ||
console.log(tl.loc('NetCore3Update')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense to print this message as we are internally deciding .net core version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this from CLIV2 task. If you think it shouldn't be displayed, I will remove it. Let me know.
fc6f567
to
c35eb3d
Compare
c35eb3d
to
b595b9c
Compare
let credCleanup = () => { return; }; | ||
|
||
const sources: Array<auth.IPackageSource> = new Array<auth.IPackageSource>(); | ||
let feedUri: string = "https://nuget.pkg.github.com/" + username + "/index.json"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just bad logic for determining the feed url....
No description provided.