Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving error logs for Invalid ARM Templates #11213

Merged
merged 10 commits into from
Aug 30, 2019

Conversation

issacnitin
Copy link
Contributor

@issacnitin issacnitin commented Aug 26, 2019

@issacnitin issacnitin requested a review from sachinma as a code owner August 26, 2019 11:00
Copy link
Contributor

@bishal-pdMSFT bishal-pdMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@bishal-pdMSFT bishal-pdMSFT removed the request for review from sachinma August 27, 2019 18:06
@issacnitin issacnitin merged commit 56bbdbb into master Aug 30, 2019
issacnitin pushed a commit that referenced this pull request Aug 30, 2019
* Fixing error logs for ARG Task

* Array.isArray condition

* Bumping version

* bug fix

* Update Tasks/AzureResourceGroupDeploymentV2/operations/ResourceGroup.ts

Co-Authored-By: Bishal Prasad <biprasad@microsoft.com>

* Review comments

* Resolving merge conflicts

* Review comments
issacnitin pushed a commit that referenced this pull request Aug 30, 2019
* Fixing error logs for ARG Task

* Array.isArray condition

* Bumping version

* bug fix

* Update Tasks/AzureResourceGroupDeploymentV2/operations/ResourceGroup.ts

Co-Authored-By: Bishal Prasad <biprasad@microsoft.com>

* Review comments

* Resolving merge conflicts

* Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants