Feature Added to Azure App Service Manage : Swap Slot with Preview #11155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaarora-ms
requested review from
kmkumaran,
SumiranAgg and
vincent1173
as code owners
eaarora-ms
requested review from
bansalaseem and
RoshanKumarMicrosoft
as code owners
SumiranAgg
reviewed
Aug 21, 2019
SumiranAgg
reviewed
Aug 21, 2019
vincent1173
reviewed
Aug 21, 2019
Tasks/AzureAppServiceManageV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
vincent1173
reviewed
Aug 21, 2019
| const webAppKindMap = new Map([ | ||
| [ 'app', 'webApp' ], | ||
| [ 'app,linux', 'webAppLinux' ], | ||
| ['app,container', 'webAppContainer'] |
There was a problem hiding this comment.
Can you ensure whether windows container apps are covered?
There was a problem hiding this comment.
Checked. All container web apps are covered.
| @@ -82,7 +85,7 @@ | |||
| "label": "Specify Slot or App Service Environment", | |||
| "defaultValue": "false", | |||
| "required": false, | |||
| "visibleRule": "Action != Swap Slots && Action != Delete Slot" | |||
| "visibleRule": "Action != Swap Slots && Action != Delete Slot && Action != Start Swap With Preview && Action != Complete Swap && Action != Cancel Swap" | |||
There was a problem hiding this comment.
Does complete swap and Cancel swap require both source and target slot?
There was a problem hiding this comment.
We need both for Complete swap but not for Cancel swap (only source slot is required) . Will make the changes.
| @@ -55,6 +55,9 @@ | |||
| "Start Azure App Service": "Start App Service", | |||
| "Stop Azure App Service": "Stop App Service", | |||
| "Restart Azure App Service": "Restart App Service", | |||
| "Start Swap With Preview" : "Start Swap with Preview", | |||
There was a problem hiding this comment.
@N-Usha, Can you check the camelcase?
vincent1173
added
Area: AzureAppService
SumiranAgg
reviewed
Aug 22, 2019
SumiranAgg
reviewed
Aug 22, 2019
|
Add L0s in azure-arm-rest-v2 |
SumiranAgg
reviewed
Aug 23, 2019
SumiranAgg
reviewed
Aug 23, 2019
SumiranAgg
reviewed
Aug 23, 2019
SumiranAgg
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following new “Actions” in the App service Manage task:
The task validates the “Action” during runtime and fails if not applicable for the selected web app type. ( Web apps on Linux as well as Web apps for containers )
Action: Start Swap with Preview
Action: Complete swap with Preview:
All inputs needed for “Swap slots” Action are needed: App service name, Resource Group, Source slot, target Slot. Checkboxes for “Swap with Production” , “Preserve Vnet”
Action: Cancel swap with Preview: (Cancel a pending swap and restore the source slot configuration)
All inputs needed for “Swap slots” Action are needed: App service name, Resource Group, Source slot, target Slot. Checkboxes for “Swap with Production” , “Preserve Vnet”
The task fails when "Start Swap with Preview" action is completed before allowing any new “Swap Slots” Action on the app giving a conflict error.
Reference: #6917