Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHubReleaseTaskV1 #11134

Merged
merged 3 commits into from
Aug 16, 2019
Merged

GitHubReleaseTaskV1 #11134

merged 3 commits into from
Aug 16, 2019

Conversation

TheLayman
Copy link
Contributor

  • Bump version and remove preview

  • For the "Tag source" input we have slight discrepancy in options. The UI options are 'Git tag' and 'User specified tag' and the YAML options are "auto" and "manual". These can be unified. Instead of auto and manual, we should rename yaml options to "gitTag", "userSpecifiedTag"

  • To make it consistent with other tasks, it would help if the options "file" and "input" for the "releaseNotesSource" input were renamed to "filePath" and "inline". If this is addressed, we can rename/alias the "release notes file" input to "releaseNotesFilePath". We should also rename the input from "releasenotes" to "releaseNotesInline":

@TheLayman TheLayman requested a review from prativen August 16, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants