New task for App service settings #11020

eaarora-ms · 2019-07-29T09:43:54Z

Release a New task called “App service Settings”/ “App service Configure” (Name is a placeholder) with the functionality to add app settings, config settings & Connection strings – All in JSON format.
We could start messaging in Logs, documentation that the App settings section will be removed from the existing app service tasks.
In the future, whenever we find a more breaking change needed to revamp the existing tasks, we will remove the “App settings” section and upgrade the major version of the tasks.

…re-pipelines-tasks into UpdateAppSettings

SumiranAgg · 2019-08-23T01:23:43Z

Tasks/AzureAppServiceSettingsV1/README.md

+
+The Azure App Service Settings task is used to update different Azure App Service settings for [Web Apps](https://azure.microsoft.com/en-in/documentation/articles/app-service-web-overview/). The task works on cross platform Azure Pipelines agents running Windows, Linux or Mac.
+
+The task works for [ASP.NET](https://www.visualstudio.com/en-us/docs/release/examples/azure/azure-web-apps-from-build-and-release-hubs), [ASP.NET Core](https://www.visualstudio.com/en-us/docs/release/examples/azure/aspnet-core10-azure-web-apps), PHP, Java, Python, Go and [Node.js](https://www.visualstudio.com/en-us/docs/release/examples/nodejs/node-to-azure-webapps) based web applications.


Since package is not an input. You may remove this. Also get this reviewed by @N-Usha

Got it reviewed. Made the changes.

…re-pipelines-tasks into UpdateAppSettings

Tasks/AzureAppServiceSettingsV1/make.json

Tasks/AzureAppServiceSettingsV1/azurewebappsettings.ts

SumiranAgg · 2019-08-23T08:19:38Z

Tasks/AzureAppServiceSettingsV1/package.json

+    "@types/mocha": "2.2.48",
+    "@types/node": "6.0.68",
+    "@types/q": "1.0.7",
+    "azurermdeploycommon": "file:../../_build/Tasks/Common/azurermdeploycommon-1.1.0.tgz",


instead of consuming entire azurermdeploy-common, consume only azure-arm-restv2

We are also using azurermdeploycommon/operations here.

Tasks/Common/AzureRmDeploy-common/azure-arm-rest/azure-arm-app-service.ts

SumiranAgg · 2019-08-23T08:26:00Z

Tasks/Common/AzureRmDeploy-common/azure-arm-rest/azure-arm-app-service.ts

+        var isNewValueUpdated: boolean = false;
+        for(var key in addProperties) {
+            if(addProperties[key].slotSetting == true) {
+                if((connectionStringSlotSettings.properties.connectionStringNames.length == 0) || (!connectionStringSlotSettings.properties.connectionStringNames.includes(key))) {


nit let connectionStringNames = connectionStringSlotSettings.properties.connectionStringNames;
Also is it possible that connectionSTringNames is null or properties is null

Already included the check 'connectionStringNames.length == 0'

SumiranAgg · 2019-08-23T08:26:15Z

Tasks/Common/AzureRmDeploy-common/azure-arm-rest/azure-arm-app-service.ts

+        var isNewValueUpdated: boolean = false;
+        for(var key in addProperties) {
+            if(addProperties[key].slotSetting == true) {
+                if((appSettingsSlotSettings.properties.appSettingNames.length == 0) || (!appSettingsSlotSettings.properties.appSettingNames.includes(addProperties[key].name))) {


nit let appSettingNames= connectionStringSlotSettings.properties.appSettingNames;
Also is it possible that connectionSTringNames is null or properties is null

Included the check for null already

…re-pipelines-tasks into UpdateAppSettings

eaarora-ms · 2019-08-26T05:42:37Z

Solved: Azure App Service Deploy - Space in app setting key fails on release #10357

eaarora-ms · 2019-08-26T05:44:37Z

Solved : #9017

New task for App service settings added

* New task for App service settings (#11020) * App Service Settings Changes (#11211) * Code owners added

eaarora-ms added 15 commits July 25, 2019 12:53

Azure Web App V2 added

1694bcd

Azure Web App Container V2 added

9ec23ca

Azure Function App V2 added

35896f1

Azure Function App Container V2 added

1365738

Azure Rm WebApp Deployment V5 added

ed3c286

Added WebAppV2

a347428

WebAppDeplyV5 updated

fd5e201

Existing App Settings parsing updated

65dd149

Version Updated

f40c556

Changes for connection string support

af7edd0

Changes for updating connection strings

1c173ae

WebAppV2 updated

477388a

No version update

b2929a1

Changes in AzureWebAppV1

09965ec

Removed WebAppV2

d07a5e0

eaarora-ms requested review from kmkumaran, SumiranAgg and vincent1173 as code owners July 29, 2019 09:43

eaarora-ms and others added 10 commits July 29, 2019 15:23

Version Updates

5e2d6f4

Changes for slot settings

5bf8ac8

Merge branch 'master' into UpdateAppSettings

e1a2f4c

version updates

976b4b2

Merge branch 'UpdateAppSettings' of https://github.com/eaarora-ms/azu…

32a739f

…re-pipelines-tasks into UpdateAppSettings

New Task Added

f1fa2eb

Slot settings added

d79b248

Merge branch 'master' into UpdateAppSettings

a4e588d

Renamed files

99f7bfc

Merge branch 'UpdateAppSettings' of https://github.com/eaarora-ms/azu…

51bf5d3

…re-pipelines-tasks into UpdateAppSettings

eaarora-ms changed the title ~~Support for Connection string added in existing task : AzureWEbAppV1~~ New task for App service settings Aug 19, 2019

Function added

9981ac4

eaarora-ms requested a review from zjrunner as a code owner August 22, 2019 12:33

eaarora-ms and others added 7 commits August 22, 2019 18:04

Merge branch 'master' into UpdateAppSettings

9ca6fbc

Changes wrt slots

c23e9a3

Merge branch 'UpdateAppSettings' of https://github.com/eaarora-ms/azu…

9ecdd83

…re-pipelines-tasks into UpdateAppSettings

App Service Manage changes

f972649

Typo corrected

61f70f2

Indentation added

eaf6516

Strings added

d7efeca

SumiranAgg reviewed Aug 23, 2019

View reviewed changes

eaarora-ms and others added 5 commits August 23, 2019 12:00

Readme Updated

b6deaf2

Merge branch 'master' into UpdateAppSettings

8c14b81

Readme updated

9a64181

Merge branch 'UpdateAppSettings' of https://github.com/eaarora-ms/azu…

ce806b6

…re-pipelines-tasks into UpdateAppSettings

Typo in readme updated

b0782f3

SumiranAgg reviewed Aug 23, 2019

View reviewed changes

Tasks/AzureAppServiceSettingsV1/make.json Outdated Show resolved Hide resolved

SumiranAgg reviewed Aug 23, 2019

View reviewed changes

Tasks/AzureAppServiceSettingsV1/azurewebappsettings.ts Outdated Show resolved Hide resolved

SumiranAgg reviewed Aug 23, 2019

View reviewed changes

Tasks/Common/AzureRmDeploy-common/azure-arm-rest/azure-arm-app-service.ts Outdated Show resolved Hide resolved

SumiranAgg reviewed Aug 23, 2019

View reviewed changes

eaarora-ms and others added 2 commits August 23, 2019 14:18

Comments reviewed

699fc00

Merge branch 'master' into UpdateAppSettings

c9f29e1

SumiranAgg approved these changes Aug 23, 2019

View reviewed changes

eaarora-ms added 2 commits August 23, 2019 17:05

Null value checked

5989933

Merge branch 'UpdateAppSettings' of https://github.com/eaarora-ms/azu…

80548d3

…re-pipelines-tasks into UpdateAppSettings

eaarora-ms merged commit 1765eed into microsoft:master Aug 23, 2019

eaarora-ms added a commit to eaarora-ms/azure-pipelines-tasks that referenced this pull request Aug 27, 2019

New task for App service settings (microsoft#11020)

4632250

New task for App service settings added

eaarora-ms added a commit that referenced this pull request Aug 27, 2019

Add App Service Settings Task to R157 (#11222)

43c0650

* New task for App service settings (#11020) * App Service Settings Changes (#11211) * Code owners added

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New task for App service settings #11020

New task for App service settings #11020

eaarora-ms commented Jul 29, 2019 •

edited

Loading

SumiranAgg Aug 23, 2019

eaarora-ms Aug 23, 2019

SumiranAgg Aug 23, 2019

eaarora-ms Aug 23, 2019

SumiranAgg Aug 23, 2019

eaarora-ms Aug 23, 2019

SumiranAgg Aug 23, 2019

eaarora-ms Aug 23, 2019

eaarora-ms commented Aug 26, 2019

eaarora-ms commented Aug 26, 2019 •

edited

Loading


		The Azure App Service Settings task is used to update different Azure App Service settings for [Web Apps](https://azure.microsoft.com/en-in/documentation/articles/app-service-web-overview/). The task works on cross platform Azure Pipelines agents running Windows, Linux or Mac.

		The task works for [ASP.NET](https://www.visualstudio.com/en-us/docs/release/examples/azure/azure-web-apps-from-build-and-release-hubs), [ASP.NET Core](https://www.visualstudio.com/en-us/docs/release/examples/azure/aspnet-core10-azure-web-apps), PHP, Java, Python, Go and [Node.js](https://www.visualstudio.com/en-us/docs/release/examples/nodejs/node-to-azure-webapps) based web applications.

New task for App service settings #11020

New task for App service settings #11020

Conversation

eaarora-ms commented Jul 29, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eaarora-ms commented Aug 26, 2019

eaarora-ms commented Aug 26, 2019 • edited Loading

eaarora-ms commented Jul 29, 2019 •

edited

Loading

eaarora-ms commented Aug 26, 2019 •

edited

Loading