[ARG task] Log detailed error for extension failure on VMs #10958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinma
reviewed
Jul 20, 2019
| @@ -30,9 +29,15 @@ export class DeploymentGroupExtensionHelper { | |||
| var listOfVms: az.VM[] = await this.azureUtils.getVMDetails(); | |||
| var extensionAddedOnVMsPromises: Promise<any>[] = []; | |||
| for (var vm of listOfVms) { | |||
| extensionAddedOnVMsPromises.push(this.addExtensionOnSingleVM(vm)); | |||
| extensionAddedOnVMsPromises.push(this.addExtensionOnSingleVM(vm).catch(err => err)); | |||
There was a problem hiding this comment.
Consider adding VM name before the error message.
There was a problem hiding this comment.
I see the message will come correctly from below. Should you rather add the VM name prefix here so that it covers all cases
Tasks/AzureResourceGroupDeploymentV2/operations/DeploymentGroupExtensionHelper.ts
Show resolved
Hide resolved
sachinma
approved these changes
Jul 22, 2019
| @@ -479,6 +479,8 @@ | |||
| "MoreInformationOnAzurePortal": "More information on Azure Portal", | |||
| "ResponseNotValid": "Response is not in a valid format", | |||
| "LogDeploymentName": "Deployment name is %s", | |||
| "ExpiredServicePrincipal": "Could not fetch access token for Azure. Verify if the Service Principal used is valid and not expired." | |||
| "ExpiredServicePrincipal": "Could not fetch access token for Azure. Verify if the Service Principal used is valid and not expired.", | |||
| "DeploymentGroupConfigurationNotSucceeded": "Deployment group configuration did not succeed on all Virtual Machines: %s", | |||
There was a problem hiding this comment.
i think we can reword the message to say ... did not succeed on one or more virtual machines.
| @@ -432,7 +432,7 @@ | |||
| "AdditionFailed": "Addition of %s on vm %s failed. Error : %s", | |||
| "DeletionFailed": "Deletion of %s on vm %s failed. Error : %s", | |||
| "DeleteAgentManually": "After the task execution completes, if the deployment group agent corresponding to the virtual machine %s is present but not active in the deployment group %s, then please delete it manually from the deployment group.", | |||
| "DGAgentOperationOnAllVMsFailed": "Deployment group agent %s did not succeed on all VMs. %s", | |||
| "DGAgentOperationOnVMFailed": "Deployment group agent %s did not succeed on VM. Error: %s", | |||
There was a problem hiding this comment.
Is this message really useful? Should we directly put the error string.
There was a problem hiding this comment.
Yes, can be done as VM extension error starts with "VM has reported a failure when processing extension 'TeamServicesAgent'"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.