Docker login issue - Don't pass isSecret to true while setting DOCKER_CONFIG variable in Docker task login. #10828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajinkya599
force-pushed
the
users/aj/DockerV2-loginIssue-m154
branch
from
346b654 to
4241855
Compare
ajinkya599
changed the title
…_CONFIG variable in Docker task login.
ajinkya599
force-pushed
the
users/aj/DockerV2-loginIssue-m154
branch
from
4241855 to
a0ab1ee
Compare
bansalaseem
approved these changes
Jul 4, 2019
ajinkya599
added a commit
that referenced
this pull request
Jul 15, 2019
…le setting DOCKER_CONFIG variable in Docker task login. (#10828)
ajinkya599
added a commit
that referenced
this pull request
Jul 15, 2019
…e setting DOCKER_CONFIG variable in Docker task login. (#10828)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting isSecret to true causes the variable to be not available as an environment variable in the sub-sequent tasks. Hence, don't set isSecret to true, so that docker commands run through script and through Docker task work correctly.
This was working with older version of task lib (vsts-task-lib) since the isSecret was not getting handled currently. Thus the variable was available as an environment variable to the subsequent tasks.