Fixed stable helm version download error #10746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,7 +68,12 @@ export async function getStableHelmVersion(): Promise<string> { | |||
| try { | |||
| const downloadPath = await toolLib.downloadTool('https://api.github.com/repos/helm/helm/releases/latest'); | |||
| const response = JSON.parse(fs.readFileSync(downloadPath, 'utf8').toString().trim()); | |||
| return response.body.tag_name; | |||
| if (!response.tag_name) | |||
There was a problem hiding this comment.
response.body.tag_name?
There was a problem hiding this comment.
it's not in body anymore
There was a problem hiding this comment.
Why do we have helmutility.ts at 2 places? Cannot we use only one?
There was a problem hiding this comment.
That's because of kubernetes-common and kubernetes-common-v2.
v2 was created to roll out the upgrade of vsts-task-lib to azure-pipelines-task-lib
There was a problem hiding this comment.
The plan is to deprecate kubernetes-common once all the dependent tasks start consuming azure-pipelines-task-lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while downloading from https://api.github.com/repos/helm/helm/releases/latest, the position of tag_name had changed. Put a check for tag_name, if tag_name cannot be extracted then returning stable version