Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 18.04 Base Image #10606

Merged
merged 10 commits into from
Jul 17, 2019
Merged

Add Ubuntu 18.04 Base Image #10606

merged 10 commits into from
Jul 17, 2019

Conversation

howlowck
Copy link
Member

@howlowck howlowck commented Jun 7, 2019

For the Packer Build VM (V1) Task, adding 18.04 LTS Base Image to the Drop down for "Gallery".

Adding 18.04 Base Image to the Drop down for "Gallery"
@howlowck howlowck requested a review from sachinma as a code owner June 7, 2019 19:37
@jasjuang
Copy link

jasjuang commented Jun 7, 2019

+1 for this!

@sachinma sachinma self-assigned this Jun 26, 2019
@sachinma sachinma requested a review from bishal-pdMSFT June 26, 2019 11:38
Copy link
Contributor

@bishal-pdMSFT bishal-pdMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update patch version in task.json

@howlowck
Copy link
Member Author

howlowck commented Jul 2, 2019

@bishal-pdMSFT I updated the patch version.

@@ -15,7 +15,7 @@
"version": {
"Major": 1,
"Minor": 0,
"Patch": 13
"Patch": 14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to build the task after updating patch version. This will update the auto-generated file task.loc.json which you should commit.

@bishal-pdMSFT
Copy link
Contributor

@howlowck can you please update the patch version

@howlowck
Copy link
Member Author

please merge when there are no further concerns.

@bishal-pdMSFT bishal-pdMSFT merged commit a0d3154 into microsoft:master Jul 17, 2019
@bishal-pdMSFT
Copy link
Contributor

Thanks @howlowck for your contribution.

@howlowck howlowck deleted the patch-1 branch July 17, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants