adding final step to delete files to remove parent folder if empty #10596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
reviewed
Jun 18, 2019
|
LGTM. Approve. |
moswald
force-pushed
the
users/maoswald/deleteEmptyFolders
branch
from
7168eee to
950154a
Compare
stephenmichaelf
approved these changes
Jun 21, 2019
moswald
force-pushed
the
users/maoswald/deleteEmptyFolders
branch
from
950154a to
c3d2b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DeleteFilestask used to leave the source folder around, but now the caller can specify they want to delete it, too.