Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support forwarding Android mappings to App Center Diagnostics #10586

Merged
merged 9 commits into from
Jun 6, 2019
Merged

Support forwarding Android mappings to App Center Diagnostics #10586

merged 9 commits into from
Jun 6, 2019

Conversation

matthiaswenz
Copy link
Contributor

  • Adds support for forwarding the Android mappings file to App Center Diagnostics
  • Mapping files don't have information which version name and version code they belong to, so the information is fetched from the uploaded release in App Center Distribution
  • Since this doesn't break existing functionality, keeps the same major version

octopotato
octopotato approved these changes Jun 5, 2019
View reviewed changes
Tasks/AppCenterDistributeV3/task.json Outdated Show resolved Hide resolved
Tasks/AppCenterDistributeV3/task.loc.json Outdated Show resolved Hide resolved
Tasks/AppCenterDistributeV3/task.loc.json Outdated Show resolved Hide resolved
bry-guy
bry-guy approved these changes Jun 5, 2019
View reviewed changes
Copy link

@bry-guy bry-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing seems a bit light, but if I remember correctly that's a limitation of the task itself. Looks thorough to me :)

@matthiaswenz matthiaswenz mentioned this pull request Jun 6, 2019
Closed
@dennispan dennispan merged commit 2522199 into microsoft:master Jun 6, 2019
@matthiaswenz matthiaswenz deleted the feature/app-center-distribute-android-mappings branch June 6, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octopotato octopotato octopotato approved these changes

@bry-guy bry-guy bry-guy approved these changes

@dennispan dennispan dennispan approved these changes

@turanuk turanuk Awaiting requested review from turanuk

@stephenmichaelf stephenmichaelf Awaiting requested review from stephenmichaelf

@hashtagchris hashtagchris Awaiting requested review from hashtagchris

@madhurig madhurig Awaiting requested review from madhurig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaswenz @dennispan @bry-guy @octopotato @evkhramkov