Swallow exceptions encountered in getHistory for DockerV2 task #10573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajinkya599
reviewed
Jun 4, 2019
ajinkya599
approved these changes
Jun 4, 2019
vincent1173
reviewed
Jun 7, 2019
| // such as --format flag not supported in old docker cli versions | ||
| output = null; | ||
| defer.resolve(); | ||
| tl.warning("Not publishing to image meta data store as get history failed with error " + e); |
There was a problem hiding this comment.
nit, warning, error and info messages should be localized :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--format flag is not supported in old docker CLI versions, so if the history output could not be resolved, then we do not want to throw error. We will not invoke publishImageDetails API, and let the docker push task complete
Associated issue- #10423