Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Publish Pipeline Artifact V1 task #10508

Conversation

jahsu-MSFT
Copy link
Contributor

@jahsu-MSFT jahsu-MSFT commented May 29, 2019

Introduces a new version (V1) of the Publish Pipeline Artifact task.

  • Primarily cleanup of the V0 task in anticipation of its upcoming GA/release
  • In preview for a sprint or two
  • No major functional changes from V0, other than relative paths now being resolved against $(System.DefaultWorkingDirectory)
  • Renamed targetPath to path (but the old name is aliased for ease-of-migration)
  • Cleanup input labels and descriptions

(internal work item)

Tasks/PublishPipelineArtifactV1/task.json Outdated Show resolved Hide resolved
Tasks/PublishPipelineArtifactV1/task.json Outdated Show resolved Hide resolved
Tasks/PublishPipelineArtifactV1/task.json Outdated Show resolved Hide resolved
Tasks/PublishPipelineArtifactV1/task.json Outdated Show resolved Hide resolved
Tasks/PublishPipelineArtifactV1/task.json Outdated Show resolved Hide resolved
Tasks/PublishPipelineArtifactV1/task.json Outdated Show resolved Hide resolved
Tasks/PublishPipelineArtifactV1/task.json Outdated Show resolved Hide resolved
Tasks/PublishPipelineArtifactV1/task.json Outdated Show resolved Hide resolved
@willsmythe willsmythe changed the title Add new publish pipeline artifact V1 task Add new Publish Pipeline Artifact V1 task May 31, 2019
@willsmythe
Copy link
Contributor

willsmythe commented May 31, 2019

@jahsu-MSFT - please use the following image for icon.png. It is a 32x32 PNG version of icon.svg (which is the nice/new icon for "publish")

icon

(if you need me to send the actual .png, let me know)

@jahsu-MSFT
Copy link
Contributor Author

jahsu-MSFT commented May 31, 2019

@willsmythe Please send me both the icon.png and icon.svg files directly. (maybe through email or Teams) The quality doesn't look quite good when I download it directly here....

Copy link
Contributor

@owenhuynMSFT owenhuynMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merging after comment has been addressed that explains what the artifact name defaults to when it's set empty.

@jahsu-MSFT jahsu-MSFT requested a review from willsmythe June 11, 2019 22:53
@jahsu-MSFT jahsu-MSFT merged commit 3e9bc2c into microsoft:master Jun 13, 2019
jahsu-MSFT added a commit to jahsu-MSFT/azure-pipelines-tasks that referenced this pull request Jun 13, 2019
…blish-pipeline-artifact-V1-task

Add new Publish Pipeline Artifact V1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants