Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving kubectutility, helmutility to kubernetes-common #10492

Merged
merged 12 commits into from
May 29, 2019
Merged

Moving kubectutility, helmutility to kubernetes-common #10492

merged 12 commits into from
May 29, 2019

Conversation

thesattiraju
Copy link
Contributor

@thesattiraju thesattiraju commented May 27, 2019 •
edited
Loading

In this PR:

  1. Moved kubectlutility and helmutility classes to kubernetes-common
  2. Removed restutility dependency from helmutility
  3. Removed few unused imports.
  4. Changed convention in kubernetes-common to comply with ts lint.
  5. Updated the tasks which are dependent on utility-common
  6. Made task changes for tasks which were dependent on kubectlutility and helmutility.

@thesattiraju thesattiraju changed the title Moving kubectutility to kubernetes-common Moving kubectutility, helmutility to kubernetes-common May 28, 2019
@thesattiraju thesattiraju requested a review from vithati May 29, 2019 06:11
vithati
vithati reviewed May 29, 2019
View reviewed changes
Tasks/Common/kubernetes-common/helmutility.ts Outdated Show resolved Hide resolved
Tasks/DownloadPackageV0/task.json Outdated Show resolved Hide resolved
Tasks/DownloadPackageV1/task.json Outdated Show resolved Hide resolved
Tasks/DuffleInstallerV0/task.json Outdated Show resolved Hide resolved
@thesattiraju thesattiraju marked this pull request as ready for review May 29, 2019 10:05
@thesattiraju thesattiraju merged commit 866830a into master May 29, 2019
@thesattiraju thesattiraju deleted the users/desattir/manifestEnhance branch June 17, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vithati vithati vithati approved these changes

@bansalaseem bansalaseem Awaiting requested review from bansalaseem

@Anumita Anumita Awaiting requested review from Anumita

@nishubansal nishubansal Awaiting requested review from nishubansal nishubansal is a code owner

@sachinma sachinma Awaiting requested review from sachinma

@zjrunner zjrunner Awaiting requested review from zjrunner

@jotaylo jotaylo Awaiting requested review from jotaylo

@madhurig madhurig Awaiting requested review from madhurig

@prativen prativen Awaiting requested review from prativen

@shyama1208 shyama1208 Awaiting requested review from shyama1208

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesattiraju @vithati