Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added retry if fetching token for SPN auth fails with status code 403 #10447

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Added retry if fetching token for SPN auth fails with status code 403 #10447

merged 2 commits into from
Jul 10, 2019

Conversation

hiyadav
Copy link
Contributor

@hiyadav hiyadav commented May 22, 2019 •
edited by bishal-pdMSFT
Loading

Fixes #10860

In case of newly created SPN, getting access token can fail with status code 403. This can happen due to SPN replication delay.
Hence, we should add retry if failure status code is 403.

@hiyadav hiyadav requested a review from Ajay-MS as a code owner May 22, 2019 06:44
@sachinma
Copy link
Member

Can u link this with an issue

@hiyadav hiyadav closed this May 24, 2019
@bishal-pdMSFT bishal-pdMSFT reopened this Jul 9, 2019
@bishal-pdMSFT bishal-pdMSFT changed the title added 403 status code for retry Added retry if fetching token for SPN auth fails with status code 403 Jul 9, 2019
@bishal-pdMSFT
Copy link
Contributor

@hiyadav I am re-opening your PR as we are seeing increased failures in ARG task getting access token for SPN.

@bishal-pdMSFT
Copy link
Contributor

@Ajay-MS @sachinma @vincentdass please review

@bishal-pdMSFT
Copy link
Contributor

#10860

@sachinma sachinma self-assigned this Jul 10, 2019
@sachinma
Copy link
Member

@bishal-pdMSFT did you verify that the issue was indeed while getting token. As per your last observations - it was while talking to ARM?

@sachinma
Copy link
Member

@bishal-pdMSFT did you verify that the issue was indeed while getting token. As per your last observations - it was while talking to ARM?

If we are actually seeing this while fetching token - the change looks okay to me

@bishal-pdMSFT
Copy link
Contributor

Yes, the error is during fetching taken.

There was another similar error which was when talking to ARM - more specifically if user has deleted resource group. last time I was talking about this error which required no fix.

@bishal-pdMSFT
Copy link
Contributor

@Ajay-MS / @vincentdass / @sachinma can you please review and approve?

@bishal-pdMSFT bishal-pdMSFT force-pushed the users/hiyada/hiyadav-patch-1 branch from d63c92e to 5fa6ca4 Compare July 10, 2019 15:31
sachinma
sachinma approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@sachinma sachinma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would probably need to update the task versions.

@bishal-pdMSFT
Copy link
Contributor

You would probably need to update the task versions.

Yes, I was not aware that we need to update all dependent tasks version now.

@bishal-pdMSFT bishal-pdMSFT merged commit 6d663ee into master Jul 10, 2019
bishal-pdMSFT added a commit that referenced this pull request Jul 10, 2019
@bishal-pdMSFT
Port from master: Added retry if fetching token for SPN auth fails wi…
134a223 
…th status code 403 (#10447)
@bishal-pdMSFT bishal-pdMSFT mentioned this pull request Jul 10, 2019
Merged
bishal-pdMSFT added a commit that referenced this pull request Jul 17, 2019
@bishal-pdMSFT
Port from master: Added retry if fetching token for SPN auth fails wi…
0f28a92 
…th status code 403 (#10872)

* Port from master: Added retry if fetching token for SPN auth fails with status code 403 (#10447)

* update KV task version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishal-pdMSFT bishal-pdMSFT bishal-pdMSFT left review comments

@sachinma sachinma sachinma approved these changes

@vincent1173 vincent1173 Awaiting requested review from vincent1173

@Ajay-MS Ajay-MS Awaiting requested review from Ajay-MS

@kasubram kasubram Awaiting requested review from kasubram

@kmkumaran kmkumaran Awaiting requested review from kmkumaran

@Lovakumar Lovakumar Awaiting requested review from Lovakumar

@madhurig madhurig Awaiting requested review from madhurig

@SumiranAgg SumiranAgg Awaiting requested review from SumiranAgg

Assignees

@sachinma sachinma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARG task fails to fetch access token for SPN if SPN is newly created
3 participants
@hiyadav @sachinma @bishal-pdMSFT