Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honoring namespace in delete, promote, reject actions #10425

Merged
merged 1 commit into from
May 21, 2019
Merged

Honoring namespace in delete, promote, reject actions #10425

merged 1 commit into from
May 21, 2019

Conversation

thesattiraju
Copy link
Contributor

--namespace <namespace> arg wasn't getting added for delete command in the kubectl-object-model, causing failures in delete, promote and reject actions, as all these actions were using delete implicitly.

@bansalaseem
Copy link
Contributor

Please add tests for your change

@thesattiraju
Copy link
Contributor Author

@bansalaseem I have added tests.

@thesattiraju thesattiraju merged commit bfaefbe into master May 21, 2019
@thesattiraju thesattiraju deleted the users/desattir/promoteFix branch May 21, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bansalaseem bansalaseem bansalaseem approved these changes

@nishubansal nishubansal Awaiting requested review from nishubansal nishubansal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesattiraju @bansalaseem