Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added advanced input field Packer version, used to build the image. #10413

Merged
merged 12 commits into from
Jun 7, 2019

Conversation

anuragc617
Copy link
Contributor

This input will give an option to user to provide the packer version to use to build the image. With this input now the packer build task will behave as follows:

  1. If packer version is provided then the highest of installed packer version on the machine and provided will be used to build the image.
  2. If the packer version input is not provided then the highest of installed and maximum supported version will be used to build the image.

@anuragc617 anuragc617 requested a review from sachinma as a code owner May 20, 2019 04:22
@bishal-pdMSFT
Copy link
Contributor

@anuragc617 @sachinma if we want the task to use user provided Packer version, should we rather have a separate tool installer task on the lines of "Use Packer"?
This will ensure that the task is supported only for a particular version of Packer and we do not get unnecessary support calls if user is trying different packer version.

@sachinma
Copy link
Member

@bishal-pdMSFT is this different from when the user has Packer version already present on the machine. Should we try to mitigate the support risk that you see by adding appropriate help text?

@bishal-pdMSFT
Copy link
Contributor

@sachinma the machine packer version support is more of a "backdoor" to be used in a minimal set of cases. Adding an explicit version input will make it appear that the task is designed to work with any packer version.
I know that there is a very thin line between these two, but other thought was to align with how other tools are installed and consumed - .net core etc.

Tasks/PackerBuildV1/src/taskParameters.ts Outdated Show resolved Hide resolved
Tasks/PackerBuildV1/task.json Outdated Show resolved Hide resolved
Tasks/PackerBuildV1/src/packerHost.ts Outdated Show resolved Hide resolved
Tasks/PackerBuildV1/task.json Outdated Show resolved Hide resolved
Tasks/PackerBuildV1/src/taskParameters.ts Show resolved Hide resolved
@anuragc617 anuragc617 merged commit b08a623 into master Jun 7, 2019
@starkmsu starkmsu deleted the packerVersionInput branch July 14, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants