Azure function app - add python runtime stack #10304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
added
Area: AzureAppService
SumiranAgg
reviewed
May 6, 2019
| @@ -27,7 +28,7 @@ export class BuiltInLinuxWebAppDeploymentProvider extends AzureRmWebAppDeploymen | |||
| var isNewValueUpdated: boolean = false; | |||
|
|
|||
| var linuxFunctionRuntimeSetting = ""; | |||
| if(this.taskParams.RuntimeStack){ | |||
| if(this.taskParams.RuntimeStack && linuxFunctionRuntimeSettingValue.get(this.taskParams.RuntimeStack)) { | |||
There was a problem hiding this comment.
User should be able to provide the exact value for runtime stack even if we dont have it in our map. Hence the logic should be, if the value is not present in our map we propagate the exact setting provided by him
There was a problem hiding this comment.
It holds good for configuration setting.
but, we update the appsetting here (dotnet / python / node) here.
SumiranAgg
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.