[KubernetesManifest] ACR based DockerRegistry endpoint #10039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakol-ms
approved these changes
Apr 5, 2019
bansalaseem
suggested changes
Apr 5, 2019
| return `docker-registry ${TaskInputParameters.secretName.trim()} --docker-username=${dockerRegistryAuth["username"]} --docker-password=${dockerRegistryAuth["password"]} --docker-server=${dockerRegistryAuth["registry"]} --docker-email=${dockerRegistryAuth["email"]}` | ||
| var registryType = tl.getInput("containerRegistryType", true); | ||
| if (registryType === "Azure Container Registry") { | ||
| let spnId = tl.getEndpointAuthorizationParameter(TaskInputParameters.dockerRegistryEndpoint, 'serviceprincipalid', true); |
There was a problem hiding this comment.
Can we have 1 copy of this code across docker/kubernetes manifest task?
There was a problem hiding this comment.
@bansalaseem moved the logic to docker-common
… users/desattir/newAuthTypeDocker
savenkat
approved these changes
Apr 5, 2019
bansalaseem
approved these changes
Apr 5, 2019
thesattiraju
added a commit
that referenced
this pull request
Apr 22, 2019
* [KubernetesManifest] Adding support for ACR based Docker Registry service connection * Refactoring dockerregistry logic to common * Fixing it in dockerCompose task
thesattiraju
added a commit
that referenced
this pull request
Apr 22, 2019
* [KubernetesManifest] ACR based DockerRegistry endpoint (#10039) * [KubernetesManifest] Adding support for ACR based Docker Registry service connection * Refactoring dockerregistry logic to common * Fixing it in dockerCompose task * Task bump up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vice connection