Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins Queue Job's 'wait for pipeline completion' should not wait on disabled jobs #7527

Closed
pjquirk opened this issue Jun 20, 2018 · 4 comments
Closed

Jenkins Queue Job's 'wait for pipeline completion' should not wait on disabled jobs #7527

pjquirk opened this issue Jun 20, 2018 · 4 comments
Assignees
@madhurig @keljos
Labels
Area: CrossPlatform

Comments

@pjquirk
Copy link
Member

pjquirk commented Jun 20, 2018

(reported in email from Rodrigo Antunes)

Issue Description

I’ve setup a TFS and Jenkins integration and the Jenkins job is triggered properly. However, when it finished, TFS build gets stuck on this step:

   locateExecution()
   pipeline, locating child execution URL:http://<redacted>/api/json
   locateExecution().requestCallback()

... I’ve detected that there were a dependent job configured on Jenkins, and that job is disabled. I would assume that TFS wouldn’t wait for it, since it’s disabled, but it seems to do.

I’ve disabled the “wait for pipeline completion” option on TFS build and it has completed successfully.

It seems that when finding jobs in the pipeline to capture, the task does not filter out disabled jobs.
@go2guy
Copy link

go2guy commented Jul 19, 2018

I'm seeing the same issue when calling a Multiphase job on Jenkins. If any of the sub jobs are disabled, Queue Jenkins job on VSTS will hang even though a successful response is recorded in Jenkins.

keljos added a commit that referenced this issue Nov 20, 2018
@keljos
Fixes for #7527, bug in how tree query parameters used, and builds fa…
208dbcd 
…iling when connection is lost while streaming jenkins console.
@keljos keljos mentioned this issue Nov 20, 2018
Merged
keljos added a commit that referenced this issue Nov 21, 2018
@keljos
Fixes for several issues in JenkinsQueueJob task (#8887)
d6f5098 
* Fixes for #7527, bug in how tree query parameters used, and builds failing when connection is lost while streaming jenkins console.

* added code comment

* changes per Pr comments
@keljos
Copy link
Member

keljos commented Nov 21, 2018

Fixed with PR #8887. Closing as fixed.

@keljos keljos closed this as completed Nov 21, 2018
@go2guy
Copy link

go2guy commented Nov 27, 2018

Is this released for consumption yet?

@keljos
Copy link
Member

keljos commented Nov 27, 2018

@go2guy The changes are being deployed. The ETA for all orgs is 12/14. Some orgs may have it earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhurig madhurig

@keljos keljos

Labels
Area: CrossPlatform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@madhurig @pjquirk @go2guy @keljos