set done when calling setResult (#8462)

microsoft · Oct 1, 2018 · ee28059 · ee28059
1 parent 91f6d06
commit ee28059
Show file tree

Hide file tree

Showing 10 changed files with 56 additions and 44 deletions.
diff --git a/Tasks/BashV3/bash.ts b/Tasks/BashV3/bash.ts
@@ -121,18 +121,24 @@ async function run() {
         // Run bash.
         let exitCode: number = await bash.exec(options);
 
+        let result = tl.TaskResult.Succeeded;
+
         // Fail on exit code.
         if (exitCode !== 0) {
-            tl.setResult(tl.TaskResult.Failed, tl.loc('JS_ExitCode', exitCode));
+            tl.error(tl.loc('JS_ExitCode', exitCode));
+            result = tl.TaskResult.Failed;
         }
 
         // Fail on stderr.
         if (stderrFailure) {
-            tl.setResult(tl.TaskResult.Failed, tl.loc('JS_Stderr'));
+            tl.error(tl.loc('JS_Stderr'));
+            result = tl.TaskResult.Failed;
         }
+
+        tl.setResult(result, null, true);
     }
     catch (err) {
-        tl.setResult(tl.TaskResult.Failed, err.message || 'run() failed');
+        tl.setResult(tl.TaskResult.Failed, err.message || 'run() failed', true);
     }
 }
 

diff --git a/Tasks/BashV3/package-lock.json b/Tasks/BashV3/package-lock.json
diff --git a/Tasks/BashV3/package.json b/Tasks/BashV3/package.json
@@ -18,6 +18,6 @@
   "homepage": "https://github.com/Microsoft/vsts-tasks#readme",
   "dependencies": {
     "uuid": "^3.0.1",
-    "vsts-task-lib": "2.0.5"
+    "vsts-task-lib": "2.7.0"
   }
 }
diff --git a/Tasks/BashV3/task.json b/Tasks/BashV3/task.json
@@ -16,7 +16,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 3,
-        "Minor": 136,
+        "Minor": 142,
         "Patch": 0
     },
     "releaseNotes": "Script task consistency. Added support for multiple lines and added support for Windows.",

diff --git a/Tasks/BashV3/task.loc.json b/Tasks/BashV3/task.loc.json
@@ -16,7 +16,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 3,
-    "Minor": 136,
+    "Minor": 142,
     "Patch": 0
   },
   "releaseNotes": "ms-resource:loc.releaseNotes",

diff --git a/Tasks/CmdLineV2/cmdline.ts b/Tasks/CmdLineV2/cmdline.ts
@@ -55,18 +55,24 @@ async function run() {
         // Run bash.
         let exitCode: number = await bash.exec(options);
 
+        let result = tl.TaskResult.Succeeded;
+
         // Fail on exit code.
         if (exitCode !== 0) {
-            tl.setResult(tl.TaskResult.Failed, tl.loc('JS_ExitCode', exitCode));
+            tl.error(tl.loc('JS_ExitCode', exitCode));
+            result = tl.TaskResult.Failed;
         }
 
         // Fail on stderr.
         if (stderrFailure) {
-            tl.setResult(tl.TaskResult.Failed, tl.loc('JS_Stderr'));
+            tl.error(tl.loc('JS_Stderr'));
+            result = tl.TaskResult.Failed;
         }
+
+        tl.setResult(result, null, true);
     }
     catch (err) {
-        tl.setResult(tl.TaskResult.Failed, err.message || 'run() failed');
+        tl.setResult(tl.TaskResult.Failed, err.message || 'run() failed', true);
     }
 }
 

diff --git a/Tasks/CmdLineV2/package-lock.json b/Tasks/CmdLineV2/package-lock.json
diff --git a/Tasks/CmdLineV2/package.json b/Tasks/CmdLineV2/package.json
@@ -18,6 +18,6 @@
   "homepage": "https://github.com/Microsoft/vsts-tasks#readme",
   "dependencies": {
     "uuid": "^3.0.1",
-    "vsts-task-lib": "2.0.5"
+    "vsts-task-lib": "2.7.0"
   }
 }
diff --git a/Tasks/CmdLineV2/task.json b/Tasks/CmdLineV2/task.json
@@ -16,7 +16,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 2,
-        "Minor": 136,
+        "Minor": 142,
         "Patch": 0
     },
     "releaseNotes": "Script task consistency. Added support for multiple lines.",

diff --git a/Tasks/CmdLineV2/task.loc.json b/Tasks/CmdLineV2/task.loc.json
@@ -16,7 +16,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 2,
-    "Minor": 136,
+    "Minor": 142,
     "Patch": 0
   },
   "releaseNotes": "ms-resource:loc.releaseNotes",